[SPARK-19674][SQL]Ignore driver accumulator updates don't belong to the execution when merging all accumulator updates #17009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
carsonwang
changed the title
|
Test build #73199 has finished for PR 17009 at commit
|
cloud-fan
reviewed
Feb 23, 2017
|
|
||
| checkAnswer(listener.getExecutionMetrics(0), accumulatorUpdates.mapValues(_ * 2)) | ||
|
|
||
| // Non-existing driver accumulator updates should be filtered and no exception will be thrown. |
Contributor
Author
There was a problem hiding this comment.
I was doing some own experiments that adds physical operators at runtime. The metrics of the added operators are not registered to the execution so I got a NoSuchElementException.
Contributor
|
The change looks reasonable, but is it |
Contributor
Author
|
Thanks @cloud-fan . |
carsonwang
changed the title
|
Test build #73333 has finished for PR 17009 at commit
|
Contributor
|
retest this please |
|
Test build #73360 has finished for PR 17009 at commit
|
Contributor
|
thanks, merging to master! |
Yunni
pushed a commit
to Yunni/spark
that referenced
this pull request
Feb 27, 2017
…the execution when merging all accumulator updates ## What changes were proposed in this pull request? In SQLListener.getExecutionMetrics, driver accumulator updates don't belong to the execution should be ignored when merging all accumulator updates to prevent NoSuchElementException. ## How was this patch tested? Updated unit test. Author: Carson Wang <[email protected]> Closes apache#17009 from carsonwang/FixSQLMetrics.
Contributor
|
It looks like this will fix a bug we're experiencing in Spark 2.1. Given that this PR is a bug fix, any chance we can get a backport into |
mallman
pushed a commit
to VideoAmp/spark-public
that referenced
this pull request
Mar 24, 2017
…the execution when merging all accumulator updates ## What changes were proposed in this pull request? In SQLListener.getExecutionMetrics, driver accumulator updates don't belong to the execution should be ignored when merging all accumulator updates to prevent NoSuchElementException. ## How was this patch tested? Updated unit test. Author: Carson Wang <[email protected]> Closes apache#17009 from carsonwang/FixSQLMetrics.
Contributor
|
I created a Spark 2.1 backport at #17418. |
asfgit
pushed a commit
that referenced
this pull request
Mar 25, 2017
[SPARK-19674][SQL] Ignore driver accumulator updates don't belong to the execution when merging all accumulator updates N.B. This is a backport to branch-2.1 of #17009. ## What changes were proposed in this pull request? In SQLListener.getExecutionMetrics, driver accumulator updates don't belong to the execution should be ignored when merging all accumulator updates to prevent NoSuchElementException. ## How was this patch tested? Updated unit test. Author: Carson Wang <carson.wangintel.com> Author: Carson Wang <[email protected]> Closes #17418 from mallman/spark-19674-backport_2.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In SQLListener.getExecutionMetrics, driver accumulator updates don't belong to the execution should be ignored when merging all accumulator updates to prevent NoSuchElementException.
How was this patch tested?
Updated unit test.