[SPARK-19617][SS]fix structured streaming restart bug #16980
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @zsxwing |
Contributor
Author
|
test this please |
Contributor
|
retest this please. |
Contributor
|
The JIRA ID is not SPARK-19645? |
Contributor
Author
|
@uncleGen The JIRA ID is 19617. But JIRA 19677 is same problem with this. |
Member
|
@gf53520 SPARK-19617 is a different issue. I guess you meant SPARK-19645. Thanks a lot for doing this. However, I merged #17012 as the approach is better and it has a unit test to cover this issue. Could you close this one please? |
Contributor
Author
|
@zsxwing no problem, But I think that PR exists an small problem that a tmp file of delta file is still reserved in hdfs. |
Member
|
Good catch. Could you submit a follow up PR to fix it? |
Contributor
Author
|
@zsxwing okay, I will submit a PR to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SPARK-19617
When restart a structured streaming job, spark will recompute WAL offsets and generate the same hdfs delta file named "currentBatchId.delta" and also generated before job restart .
How was this patch tested?
manual tests