Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Feb 15, 2017

What changes were proposed in this pull request?

#16940 adds a test case which does not stop the spark job. It causes many failures of other test cases.

[info]   org.apache.spark.SparkException: Only one SparkContext may be running in this JVM (see SPARK-2243). To ignore this error, set spark.driver.allowMultipleContexts = true. The currently running SparkContext was created at:

How was this patch tested?

Pass the Jenkins test.

@rxin
Copy link
Contributor

rxin commented Feb 15, 2017

Merging in master.


assert(df.queryExecution === queryExecution)

spark.stop()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dongjoon-hyun should we do this in a try..finally?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry. @hvanhovell . Should I make another followup PR for that to be safer?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, lets leave as it is.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Thanks!

@asfgit asfgit closed this in 59dc26e Feb 15, 2017
@SparkQA
Copy link

SparkQA commented Feb 15, 2017

Test build #72950 has finished for PR 16943 at commit 491704f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

cmonkey pushed a commit to cmonkey/spark that referenced this pull request Feb 16, 2017
…ecutionId

## What changes were proposed in this pull request?

apache#16940 adds a test case which does not stop the spark job. It causes many failures of other test cases.

- https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-master-test-sbt-hadoop-2.7/2403/consoleFull
- https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-master-test-maven-hadoop-2.7/2600/consoleFull

```
[info]   org.apache.spark.SparkException: Only one SparkContext may be running in this JVM (see SPARK-2243). To ignore this error, set spark.driver.allowMultipleContexts = true. The currently running SparkContext was created at:
```

## How was this patch tested?

Pass the Jenkins test.

Author: Dongjoon Hyun <[email protected]>

Closes apache#16943 from dongjoon-hyun/SPARK-19607-2.
@dongjoon-hyun dongjoon-hyun deleted the SPARK-19607-2 branch February 16, 2017 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants