Skip to content

Conversation

@yhuai
Copy link
Contributor

@yhuai yhuai commented Feb 15, 2017

What changes were proposed in this pull request?

Right now, we only have info level log after we finish the tests of a Python test file. We should also log the start of a test. So, if a test is hanging, we can tell which test file is running.

How was this patch tested?

This is a change for python tests.

… Python test file. We should also log the start of a test. So, if a test is hanging, we can tell which test file is running.
@SparkQA
Copy link

SparkQA commented Feb 15, 2017

Test build #72919 has finished for PR 16935 at commit 1181cc3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor Author

yhuai commented Feb 15, 2017

Let's not merge it right now. I may need to log more.

@yhuai
Copy link
Contributor Author

yhuai commented Feb 15, 2017

ok. Nothing new to add. I will merge this to master and branch-2.1 (in case we want to debug any python test hanging issue in branch-2.1).

@liancheng
Copy link
Contributor

Merging to master an branch-2.1.

@yhuai
Copy link
Contributor Author

yhuai commented Feb 15, 2017

Seems I cannot merge now... Will try again later.

@liancheng
Copy link
Contributor

Me neither...

@asfgit asfgit closed this in f6c3bba Feb 16, 2017
asfgit pushed a commit that referenced this pull request Feb 16, 2017
## What changes were proposed in this pull request?
Right now, we only have info level log after we finish the tests of a Python test file. We should also log the start of a test. So, if a test is hanging, we can tell which test file is running.

## How was this patch tested?
This is a change for python tests.

Author: Yin Huai <[email protected]>

Closes #16935 from yhuai/SPARK-19604.

(cherry picked from commit f6c3bba)
Signed-off-by: Yin Huai <[email protected]>
@yhuai
Copy link
Contributor Author

yhuai commented Feb 16, 2017

cool. It has been merged.

cmonkey pushed a commit to cmonkey/spark that referenced this pull request Feb 16, 2017
## What changes were proposed in this pull request?
Right now, we only have info level log after we finish the tests of a Python test file. We should also log the start of a test. So, if a test is hanging, we can tell which test file is running.

## How was this patch tested?
This is a change for python tests.

Author: Yin Huai <[email protected]>

Closes apache#16935 from yhuai/SPARK-19604.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants