[SPARK-19590][pyspark][ML] Update the document for QuantileDiscretizer in pyspark #16922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinceShieh
changed the title
|
Test build #72850 has finished for PR 16922 at commit
|
VinceShieh
force-pushed
the
spark-19590
branch
from
25bdc0f to
9ce7cb8
Compare
|
Test build #72851 has finished for PR 16922 at commit
|
…r in pyspark This PR is to document the change on QuantileDiscretizer in pyspark for PR: apache#15428 Signed-off-by: VinceShieh <[email protected]>
VinceShieh
force-pushed
the
spark-19590
branch
from
9ce7cb8 to
c5e46fb
Compare
|
Test build #72852 has finished for PR 16922 at commit
|
holdenk
reviewed
Feb 14, 2017
Contributor
holdenk
left a comment
holdenk
left a comment
There was a problem hiding this comment.
Thanks for following through and updating the Python documentation as well :) One minor question :)
python/pyspark/ml/feature.py
Outdated
| NaN handling: Note also that | ||
| QuantileDiscretizer will raise an error when it finds NaN values in the dataset, but the user | ||
| can also choose to either keep or remove NaN values within the dataset by setting | ||
| `handleInvalid`. If the user chooses to keep NaN values, they will be handled specially and |
Contributor
There was a problem hiding this comment.
could we maybe link this with a py attr like we did with numBuckets?
Author
There was a problem hiding this comment.
yeah, sure. Thanks for pointing that out... ;)
Signed-off-by: VinceShieh <[email protected]>
|
Test build #72908 has finished for PR 16922 at commit
|
Contributor
|
Thanks for doing the follow up Python work, merged to master :) |
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Feb 16, 2017
…r in pyspark ## What changes were proposed in this pull request? This PR is to document the changes on QuantileDiscretizer in pyspark for PR: apache#15428 ## How was this patch tested? No test needed Signed-off-by: VinceShieh <vincent.xieintel.com> Author: VinceShieh <[email protected]> Closes apache#16922 from VinceShieh/spark-19590.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is to document the changes on QuantileDiscretizer in pyspark for PR:
#15428
How was this patch tested?
No test needed
Signed-off-by: VinceShieh [email protected]