[SPARK-19542][SS]Delete the temp checkpoint if a query is stopped without errors #16880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #72680 has finished for PR 16880 at commit
|
|
Test build #72682 has finished for PR 16880 at commit
|
brkyvz
reviewed
Feb 10, 2017
| val fs = checkpointPath.getFileSystem(sparkSession.sessionState.newHadoopConf()) | ||
| fs.delete(checkpointPath, true) | ||
| } catch { | ||
| case e: IOException => |
Contributor
There was a problem hiding this comment.
I don't think so, but can we get any other exception here? It could be bad if it bubbles up to an uncaught exception handler.
Member
Author
There was a problem hiding this comment.
Good point. I changed it to NonFatal.
Contributor
|
LGTM. I left one question, but then checked and found the answer. |
|
Test build #72721 has finished for PR 16880 at commit
|
Contributor
|
LGTM! Merging to master and 2.1. |
asfgit
pushed a commit
that referenced
this pull request
Feb 13, 2017
…thout errors ## What changes were proposed in this pull request? When a query uses a temp checkpoint dir, it's better to delete it if it's stopped without errors. ## How was this patch tested? New unit tests. Author: Shixiong Zhu <[email protected]> Closes #16880 from zsxwing/delete-temp-checkpoint. (cherry picked from commit 3dbff9b) Signed-off-by: Burak Yavuz <[email protected]>
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Feb 15, 2017
…thout errors ## What changes were proposed in this pull request? When a query uses a temp checkpoint dir, it's better to delete it if it's stopped without errors. ## How was this patch tested? New unit tests. Author: Shixiong Zhu <[email protected]> Closes apache#16880 from zsxwing/delete-temp-checkpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When a query uses a temp checkpoint dir, it's better to delete it if it's stopped without errors.
How was this patch tested?
New unit tests.