[SPARK-19509][SQL] Grouping Sets do not respect nullable grouping columns #16873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
Author
|
also cc @stanzhai |
|
Test build #72645 has finished for PR 16873 at commit
|
jiangxb1987
reviewed
Feb 9, 2017
|
|
||
|
|
||
| DROP VIEW IF EXISTS grouping; | ||
| DROP VIEW IF EXISTS grouping_null; |
Contributor
There was a problem hiding this comment.
Nit: Should we leave an extra empty line for the end of this file?
Contributor
Author
There was a problem hiding this comment.
Yeah lemme fix that.
Contributor
|
Thank you for ccing me @hvanhovell ! This PR looks good to me. |
|
Test build #72653 has finished for PR 16873 at commit
|
Contributor
Author
|
I am merging this. |
asfgit
pushed a commit
that referenced
this pull request
Feb 9, 2017
…umns ## What changes were proposed in this pull request? The analyzer currently does not check if a column used in grouping sets is actually nullable itself. This can cause the nullability of the column to be incorrect, which can cause null pointer exceptions down the line. This PR fixes that by also consider the nullability of the column. This is only a problem for Spark 2.1 and below. The latest master uses a different approach. Closes #16874 ## How was this patch tested? Added a regression test to `SQLQueryTestSuite.grouping_set`. Author: Herman van Hovell <[email protected]> Closes #16873 from hvanhovell/SPARK-19509.
asfgit
pushed a commit
that referenced
this pull request
Feb 9, 2017
…umns ## What changes were proposed in this pull request? The analyzer currently does not check if a column used in grouping sets is actually nullable itself. This can cause the nullability of the column to be incorrect, which can cause null pointer exceptions down the line. This PR fixes that by also consider the nullability of the column. This is only a problem for Spark 2.1 and below. The latest master uses a different approach. Closes #16874 ## How was this patch tested? Added a regression test to `SQLQueryTestSuite.grouping_set`. Author: Herman van Hovell <[email protected]> Closes #16873 from hvanhovell/SPARK-19509. (cherry picked from commit a3d5300) Signed-off-by: Herman van Hovell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The analyzer currently does not check if a column used in grouping sets is actually nullable itself. This can cause the nullability of the column to be incorrect, which can cause null pointer exceptions down the line. This PR fixes that by also consider the nullability of the column.
This is only a problem for Spark 2.1 and below. The latest master uses a different approach.
Closes #16874
How was this patch tested?
Added a regression test to
SQLQueryTestSuite.grouping_set.