Skip to content

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Feb 7, 2017

What changes were proposed in this pull request?

This pull request makes SQLConf slightly more extensible by removing the visibility limitations on the build* functions.

How was this patch tested?

N/A - there are no logic changes and everything should be covered by existing unit tests.

.intConf
.createWithDefault(4000)
val SCHEMA_STRING_LENGTH_THRESHOLD =
buildStaticConf("spark.sql.sources.schemaStringLengthThreshold")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit identation

@hvanhovell
Copy link
Contributor

LGTM

@SparkQA
Copy link

SparkQA commented Feb 7, 2017

Test build #72510 has finished for PR 16835 at commit c004013.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor Author

rxin commented Feb 7, 2017

Merging in master.

@asfgit asfgit closed this in b7277e0 Feb 7, 2017
@SparkQA
Copy link

SparkQA commented Feb 7, 2017

Test build #72516 has finished for PR 16835 at commit 7de10c3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

cmonkey pushed a commit to cmonkey/spark that referenced this pull request Feb 15, 2017
## What changes were proposed in this pull request?
This pull request makes SQLConf slightly more extensible by removing the visibility limitations on the build* functions.

## How was this patch tested?
N/A - there are no logic changes and everything should be covered by existing unit tests.

Author: Reynold Xin <[email protected]>

Closes apache#16835 from rxin/SPARK-19495.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants