Skip to content

Conversation

@cenyuhai
Copy link
Contributor

@cenyuhai cenyuhai commented Feb 7, 2017

What changes were proposed in this pull request?

ignore hive column names case-sensitive when comparing with partition columns

How was this patch tested?

@cenyuhai cenyuhai changed the title [SPARK-19490][SQL] change column names to lower case [SPARK-19490][SQL] change hive column names to lower case Feb 7, 2017
@rxin
Copy link
Contributor

rxin commented Feb 7, 2017

hm is it safe to just do this change?

@SparkQA
Copy link

SparkQA commented Feb 7, 2017

Test build #72501 has finished for PR 16832 at commit efb0b4b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cenyuhai
Copy link
Contributor Author

@rxin I think it is safe, it is only used to check whether the schema contains the columns. Hive columns are not case-sensitive.

@SparkQA
Copy link

SparkQA commented Feb 10, 2017

Test build #72689 has started for PR 16832 at commit 6884ad3.

@cenyuhai cenyuhai changed the title [SPARK-19490][SQL] change hive column names to lower case [WIP][SPARK-19490][SQL] change hive column names to lower case Feb 12, 2017
@cenyuhai cenyuhai changed the title [WIP][SPARK-19490][SQL] change hive column names to lower case [WIP][SPARK-19490][SQL] ignore hive column names case-sensitive when comparing with partition columns Feb 12, 2017
@cenyuhai cenyuhai changed the title [WIP][SPARK-19490][SQL] ignore hive column names case-sensitive when comparing with partition columns [WIP][SPARK-19490][SQL] ignore case-sensitive when filtering hive partition columns Feb 12, 2017
@cenyuhai cenyuhai changed the title [WIP][SPARK-19490][SQL] ignore case-sensitive when filtering hive partition columns [WIP][SPARK-19490][SQL] ignore case sensitivity when filtering hive partition columns Feb 12, 2017
@SparkQA
Copy link

SparkQA commented Feb 12, 2017

Test build #72750 has finished for PR 16832 at commit 7214b8a.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Feb 12, 2017

Test build #72755 has finished for PR 16832 at commit b734646.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Feb 12, 2017

Test build #72758 has finished for PR 16832 at commit 358769c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Feb 12, 2017

Test build #72763 has started for PR 16832 at commit 5e91877.

@SparkQA
Copy link

SparkQA commented Feb 22, 2017

Test build #73267 has started for PR 16832 at commit f790821.

@SparkQA
Copy link

SparkQA commented Feb 22, 2017

Test build #73275 has finished for PR 16832 at commit c3f7444.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Feb 22, 2017

Test build #73278 has finished for PR 16832 at commit c9dd09b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cenyuhai cenyuhai changed the title [WIP][SPARK-19490][SQL] ignore case sensitivity when filtering hive partition columns [SPARK-19490][SQL] ignore case sensitivity when filtering hive partition columns Feb 23, 2017
@janua
Copy link

janua commented Apr 26, 2017

👍
Just bumped into this issue. The error message doesn't make it obvious what's wrong.

@taklwu
Copy link

taklwu commented Jun 9, 2017

any updates on this PR?

@cenyuhai
Copy link
Contributor Author

@taklwu this pr is completed, you can merge this pr by yourself. A committer told me that other pr has fixed this bug, my pr will not be merged......

@taklwu
Copy link

taklwu commented Jun 17, 2017

May I get the link of which commit/pr fix this issue? thanks a lot

@LantaoJin
Copy link
Contributor

Duplicates to SPARK-18572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants