[SPARK-19444][ML][Documentation] Fix imports not being present in documentation #16789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@anshbansal before opening any more PRs or JIRAs please read http://spark.apache.org/contributing.html |
Member
|
Ping @anshbansal |
Contributor
Author
|
@srowen Will read them and get back |
anshbansal
changed the title
|
Test build #3557 has finished for PR 16789 at commit
|
Member
|
Merged to master/2.1 |
asfgit
pushed a commit
that referenced
this pull request
Feb 7, 2017
…umentation ## What changes were proposed in this pull request? SPARK-19444 imports not being present in documentation ## How was this patch tested? Manual ## Disclaimer Contribution is original work and I license the work to the project under the project’s open source license Author: Aseem Bansal <[email protected]> Closes #16789 from anshbansal/patch-1. (cherry picked from commit aee2bd2) Signed-off-by: Sean Owen <[email protected]>
gatorsmile
reviewed
Feb 13, 2017
| import static org.apache.spark.sql.functions.callUDF; | ||
| import static org.apache.spark.sql.functions.col; | ||
| // $example off:untyped_ops$ | ||
| // $example off |
Member
There was a problem hiding this comment.
PS I actually fixed this in my big "Java 8" PR for SPARK-19550 because I needed to get the examples to compile. If we don't get that merged soon yes let's fix this in a quick PR
Member
There was a problem hiding this comment.
I hit this issue when I tried to review a Documentation-related PR. Thus, I submitted the PR.
asfgit
pushed a commit
that referenced
this pull request
Feb 13, 2017
…amount is not equal to end indices amount ### What changes were proposed in this pull request? ``` Liquid Exception: Start indices amount is not equal to end indices amount, see /Users/xiao/IdeaProjects/sparkDelivery/docs/../examples/src/main/java/org/apache/spark/examples/ml/JavaTokenizerExample.java. in ml-features.md ``` So far, the build is broken after merging #16789 This PR is to fix it. ## How was this patch tested? Manual Author: Xiao Li <[email protected]> Closes #16908 from gatorsmile/docMLFix. (cherry picked from commit 855a1b7) Signed-off-by: Sean Owen <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Feb 13, 2017
…amount is not equal to end indices amount ### What changes were proposed in this pull request? ``` Liquid Exception: Start indices amount is not equal to end indices amount, see /Users/xiao/IdeaProjects/sparkDelivery/docs/../examples/src/main/java/org/apache/spark/examples/ml/JavaTokenizerExample.java. in ml-features.md ``` So far, the build is broken after merging #16789 This PR is to fix it. ## How was this patch tested? Manual Author: Xiao Li <[email protected]> Closes #16908 from gatorsmile/docMLFix.
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Feb 15, 2017
…umentation ## What changes were proposed in this pull request? SPARK-19444 imports not being present in documentation ## How was this patch tested? Manual ## Disclaimer Contribution is original work and I license the work to the project under the project’s open source license Author: Aseem Bansal <[email protected]> Closes apache#16789 from anshbansal/patch-1.
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Feb 15, 2017
…amount is not equal to end indices amount ### What changes were proposed in this pull request? ``` Liquid Exception: Start indices amount is not equal to end indices amount, see /Users/xiao/IdeaProjects/sparkDelivery/docs/../examples/src/main/java/org/apache/spark/examples/ml/JavaTokenizerExample.java. in ml-features.md ``` So far, the build is broken after merging apache#16789 This PR is to fix it. ## How was this patch tested? Manual Author: Xiao Li <[email protected]> Closes apache#16908 from gatorsmile/docMLFix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SPARK-19444 imports not being present in documentation
How was this patch tested?
Manual
Disclaimer
Contribution is original work and I license the work to the project under the project’s open source license