[SPARK-19330][DStreams] Also show tooltip for successful batches #16673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
reviewed
Jan 22, 2017
| .attr("cx", function(d) { return x(d.x); }) | ||
| .attr("cy", function(d) { return y(d.y); }) | ||
| .attr("r", function(d) { return isFailedBatch(d.x) ? "2" : "0";}) | ||
| .attr("r", function(d) { return isFailedBatch(d.x) ? "2" : "3";}) |
Contributor
Author
There was a problem hiding this comment.
This changes the radius of a blue dot (which represents a successful batch) in the svg.
Prior to this patch, the radius was 0 thus the blue dot could hardly be hovered and tooltip would not show. This patch alters the radius to 3 for each blue dot.
|
Test build #71804 has finished for PR 16673 at commit
|
Contributor
|
Sorry, I do not get your point. Do you mean the precessing time detail can not be shown on line? But I can not reproduce it, and everything works well. |
Contributor
Author
|
@uncleGen yea I mean the tooltip nearly won't show for a blue dot (which represents a successful batch) when the cursor hovers above the blue dot in the 'processing time' graph. |
Contributor
Author
|
@zsxwing would you take a look, thanks! |
Member
|
Yeah, much easier to see the batch tooltip after this change. LGTM. Thanks! Merging to master and 2.1. |
asfgit
pushed a commit
that referenced
this pull request
Jan 25, 2017
## What changes were proposed in this pull request? ### Before  ### After  ## How was this patch tested? Manually Author: Liwei Lin <[email protected]> Closes #16673 from lw-lin/streaming. (cherry picked from commit 40a4cfc) Signed-off-by: Shixiong Zhu <[email protected]>
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? ### Before  ### After  ## How was this patch tested? Manually Author: Liwei Lin <[email protected]> Closes apache#16673 from lw-lin/streaming.
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Feb 15, 2017
## What changes were proposed in this pull request? ### Before  ### After  ## How was this patch tested? Manually Author: Liwei Lin <[email protected]> Closes apache#16673 from lw-lin/streaming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Before
After
How was this patch tested?
Manually