[SPARK-19242][SQL] SHOW CREATE TABLE should generate new syntax to create hive table #16600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
commented
Jan 16, 2017
| case MANAGED => " TABLE" | ||
| builder ++= s" AS\n${tableMeta.viewText.get}" | ||
| builder.toString | ||
| } else if (DDLUtils.isHiveTable(tableMeta) && tableMeta.properties.nonEmpty) { |
Contributor
Author
There was a problem hiding this comment.
this condition is true most of the time, because Hive metastore will generate some table properties. https://issues.apache.org/jira/browse/SPARK-19241 is tracking it
|
Test build #71440 has finished for PR 16600 at commit
|
Member
|
cc @cloud-fan |
|
Test build #81849 has started for PR 16600 at commit |
|
Test FAILed. |
Contributor
|
Can you close this pr? |
Contributor
Author
|
We will revisit it after we completely make hive a data source. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
after #16296 , we have a new unified CREATE TABLE syntax,
SHOW CREATE TABLEshould also generate SQL statement using the new syntax.However, the new syntax doesn't support table properties,
SHOW CREATE TABLEmay still generate legacy hive syntax if table properties are not empty.How was this patch tested?
existing tests