[SPARK-19158][SPARKR][EXAMPLES] Fix ml.R example fails due to lack of e1071 package. #16548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
approved these changes
Jan 11, 2017
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
Yeah, why did this ever depend on e1071? doesn't seem essential.
|
Test build #71204 has finished for PR 16548 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Jan 12, 2017
… e1071 package. ## What changes were proposed in this pull request? ```ml.R``` example depends on ```e1071``` package, if it's not available in users' environment, it will fail. I think the example should not depends on third-party packages, so I update it to remove the dependency. ## How was this patch tested? Manual test. Author: Yanbo Liang <[email protected]> Closes #16548 from yanboliang/spark-19158. (cherry picked from commit 2c586f5) Signed-off-by: Yanbo Liang <[email protected]>
Contributor
Author
|
Merged into master and branch-2.1. Thanks for reviewing. |
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
… e1071 package. ## What changes were proposed in this pull request? ```ml.R``` example depends on ```e1071``` package, if it's not available in users' environment, it will fail. I think the example should not depends on third-party packages, so I update it to remove the dependency. ## How was this patch tested? Manual test. Author: Yanbo Liang <[email protected]> Closes apache#16548 from yanboliang/spark-19158.
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Feb 15, 2017
… e1071 package. ## What changes were proposed in this pull request? ```ml.R``` example depends on ```e1071``` package, if it's not available in users' environment, it will fail. I think the example should not depends on third-party packages, so I update it to remove the dependency. ## How was this patch tested? Manual test. Author: Yanbo Liang <[email protected]> Closes apache#16548 from yanboliang/spark-19158.
Contributor
|
So there is something similar in the fulltests for R |
Contributor
Author
|
@holdenk Could you let me know where we meet similar issue in the fulltests? AFAIK, we test functions in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ml.Rexample depends one1071package, if it's not available in users' environment, it will fail. I think the example should not depends on third-party packages, so I update it to remove the dependency.How was this patch tested?
Manual test.