[SPARK-19110][MLLIB][FollowUP]: Add a unit test for testing logPrior and logLikelihood of DistributedLDAModel in MLLIB #16524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #71102 has finished for PR 16524 at commit
|
Member
|
@wangmiao1981 a more descriptive title would help -- test for what? |
wangmiao1981
changed the title
Contributor
Author
|
@srowen Title is updated. Unit tests for [ML] have been added in the original fix, but the MLLIB case is not added. So this followup adds back a simple unit test for the two parameters of DistributedLDAModel. Thanks! |
Member
|
LGTM |
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…nd logLikelihood of DistributedLDAModel in MLLIB ## What changes were proposed in this pull request? apache#16491 added the fix to mllib and a unit test to ml. This followup PR, add unit tests to mllib suite. ## How was this patch tested? Unit tests. Author: [email protected] <[email protected]> Closes apache#16524 from wangmiao1981/ldabug.
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Feb 15, 2017
…nd logLikelihood of DistributedLDAModel in MLLIB ## What changes were proposed in this pull request? apache#16491 added the fix to mllib and a unit test to ml. This followup PR, add unit tests to mllib suite. ## How was this patch tested? Unit tests. Author: [email protected] <[email protected]> Closes apache#16524 from wangmiao1981/ldabug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#16491 added the fix to mllib and a unit test to ml. This followup PR, add unit tests to mllib suite.
How was this patch tested?
Unit tests.