[SPARK-19130][SPARKR] Support setting literal value as column implicitly #16510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #71059 has finished for PR 16510 at commit
|
|
Test build #71062 has finished for PR 16510 at commit
|
Contributor
|
This is pretty useful! |
shivaram
reviewed
Jan 11, 2017
Contributor
shivaram
left a comment
shivaram
left a comment
There was a problem hiding this comment.
Thanks @felixcheung - LGTM.
R/pkg/R/DataFrame.R
Outdated
| if (isAtomicLengthOne(value)) { | ||
| value <- lit(value) | ||
| } else { | ||
| stop("value must be a Column, Literal value as atomic in length of 1, or NULL") |
Contributor
There was a problem hiding this comment.
nit - it must be literal (no caps ?)
Member
Author
There was a problem hiding this comment.
I was thinking org.apache.spark.sql.catalyst.expressions.Literal as the type, but I guess i can use the lower case term too
|
Test build #71183 has finished for PR 16510 at commit
|
Contributor
|
Merging this to master, branch-2.1 |
asfgit
pushed a commit
that referenced
this pull request
Jan 11, 2017
## What changes were proposed in this pull request? ``` df$foo <- 1 ``` instead of ``` df$foo <- lit(1) ``` ## How was this patch tested? unit tests Author: Felix Cheung <[email protected]> Closes #16510 from felixcheung/rlitcol. (cherry picked from commit d749c06) Signed-off-by: Shivaram Venkataraman <[email protected]>
Contributor
|
I can't update JIRA as it seems to be down right now ? (Getting a 503) - Anyways I'll check again in a few hours |
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? ``` df$foo <- 1 ``` instead of ``` df$foo <- lit(1) ``` ## How was this patch tested? unit tests Author: Felix Cheung <[email protected]> Closes apache#16510 from felixcheung/rlitcol.
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Feb 15, 2017
## What changes were proposed in this pull request? ``` df$foo <- 1 ``` instead of ``` df$foo <- lit(1) ``` ## How was this patch tested? unit tests Author: Felix Cheung <[email protected]> Closes apache#16510 from felixcheung/rlitcol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
instead of
How was this patch tested?
unit tests