[SPARK-19127][DOCS] Update Rank Function Documentation #16505
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatorsmile
reviewed
Jan 8, 2017
R/pkg/R/functions.R
Outdated
| #' Window function: returns the rank of rows within a window partition. | ||
| #' | ||
| #' The difference between rank and denseRank is that denseRank leaves no gaps in ranking | ||
| #' sequence when there are ties. That is, if you were ranking a competition using denseRank |
Member
There was a problem hiding this comment.
The above two lines also have denseRank. To be consistent, we also should rename it to dense_rank
Contributor
Author
There was a problem hiding this comment.
added, thanks for the feedback.
|
Test build #71043 has finished for PR 16505 at commit
|
Contributor
|
Thanks - merging in master/branch-2.1. |
asfgit
pushed a commit
that referenced
this pull request
Jan 9, 2017
## What changes were proposed in this pull request? - [X] Fix inconsistencies in function reference for dense rank and dense - [X] Make all languages equivalent in their reference to `dense_rank` and `rank`. ## How was this patch tested? N/A for docs. Please review http://spark.apache.org/contributing.html before opening a pull request. Author: anabranch <[email protected]> Closes #16505 from anabranch/SPARK-19127. (cherry picked from commit 1f6ded6) Signed-off-by: Reynold Xin <[email protected]>
|
Test build #71045 has finished for PR 16505 at commit
|
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Jan 9, 2017
## What changes were proposed in this pull request? - [X] Fix inconsistencies in function reference for dense rank and dense - [X] Make all languages equivalent in their reference to `dense_rank` and `rank`. ## How was this patch tested? N/A for docs. Please review http://spark.apache.org/contributing.html before opening a pull request. Author: anabranch <[email protected]> Closes apache#16505 from anabranch/SPARK-19127.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? - [X] Fix inconsistencies in function reference for dense rank and dense - [X] Make all languages equivalent in their reference to `dense_rank` and `rank`. ## How was this patch tested? N/A for docs. Please review http://spark.apache.org/contributing.html before opening a pull request. Author: anabranch <[email protected]> Closes apache#16505 from anabranch/SPARK-19127.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
dense_rankandrank.How was this patch tested?
N/A for docs.
Please review http://spark.apache.org/contributing.html before opening a pull request.