Skip to content

Conversation

@shimingfei
Copy link

What changes were proposed in this pull request?

LauncherState should be only set to SUBMITTED after the application is submitted.
Currently the state is set before the application is actually submitted.

How was this patch tested?

no test is added in this patch

@SparkQA
Copy link

SparkQA commented Jan 3, 2017

Test build #70816 has finished for PR 16459 at commit 312fb9c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jan 3, 2017

(This would require a JIRA)
CC @vanzin or @steveloughran ?

@vanzin
Copy link
Contributor

vanzin commented Jan 3, 2017

LGTM but please open a bug.

@shimingfei shimingfei changed the title [MINOR] LauncherState should be only set to SUBMITTED after the application is submitted [SPARK-19073] LauncherState should be only set to SUBMITTED after the application is submitted Jan 4, 2017
@shimingfei
Copy link
Author

@srowen @vanzin I have opened an issue on the JIRA. Thanks

@asfgit asfgit closed this in fe1c895 Jan 4, 2017
@srowen
Copy link
Member

srowen commented Jan 5, 2017

Merged to master

cmonkey pushed a commit to cmonkey/spark that referenced this pull request Jan 9, 2017
… application is submitted

## What changes were proposed in this pull request?
LauncherState should be only set to SUBMITTED after the application is submitted.
Currently the state is set before the application is actually submitted.

## How was this patch tested?
no test is added in this patch

Author: mingfei <[email protected]>

Closes apache#16459 from shimingfei/fixLauncher.
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
… application is submitted

## What changes were proposed in this pull request?
LauncherState should be only set to SUBMITTED after the application is submitted.
Currently the state is set before the application is actually submitted.

## How was this patch tested?
no test is added in this patch

Author: mingfei <[email protected]>

Closes apache#16459 from shimingfei/fixLauncher.
@shimingfei shimingfei deleted the fixLauncher branch May 23, 2017 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants