[SPARK-19048] [SQL] Delete Partition Location when Dropping Managed Partitioned Tables in InMemoryCatalog #16448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatorsmile
commented
Jan 1, 2017
| * Add Partition in ALTER TABLE: add the table partitions. | ||
| * | ||
| * 'partitionSpecsAndLocs': the syntax of ALTER VIEW is identical to ALTER TABLE, | ||
| * EXCEPT that it is ILLEGAL to specify a LOCATION clause. |
Member
Author
There was a problem hiding this comment.
We do not support ALTER VIEW ADD PARTITION
gatorsmile
commented
Jan 1, 2017
| assert(e.message == "Found duplicate column(s) in table definition of `tbl`: a") | ||
| } | ||
|
|
||
| test("add/drop partition with location - managed table") { |
Member
Author
There was a problem hiding this comment.
This is to improve the test coverage of Hive External Catalog.
|
Test build #70776 has finished for PR 16448 at commit
|
Member
Author
|
retest this please |
|
Test build #70784 has finished for PR 16448 at commit
|
Member
Author
|
cc @cloud-fan @yhuai |
cloud-fan
reviewed
Jan 3, 2017
| val table = CatalogTable( | ||
| identifier = TableIdentifier("tbl", Some("db1")), | ||
| tableType = CatalogTableType.MANAGED, | ||
| storage = CatalogStorageFormat(None, None, None, None, false, Map.empty), |
Contributor
There was a problem hiding this comment.
nit: CatalogStorageFormat.empty
Contributor
|
LGTM |
|
Test build #70796 has started for PR 16448 at commit |
Contributor
|
retest this please |
|
Test build #70817 has finished for PR 16448 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Jan 3, 2017
…rtitioned Tables in InMemoryCatalog ### What changes were proposed in this pull request? The data in the managed table should be deleted after table is dropped. However, if the partition location is not under the location of the partitioned table, it is not deleted as expected. Users can specify any location for the partition when they adding a partition. This PR is to delete partition location when dropping managed partitioned tables stored in `InMemoryCatalog`. ### How was this patch tested? Added test cases for both HiveExternalCatalog and InMemoryCatalog Author: gatorsmile <[email protected]> Closes #16448 from gatorsmile/unsetSerdeProp. (cherry picked from commit b67b35f) Signed-off-by: gatorsmile <[email protected]>
Member
Author
|
Thanks! Merging to master/2.1 |
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Jan 4, 2017
…rtitioned Tables in InMemoryCatalog ### What changes were proposed in this pull request? The data in the managed table should be deleted after table is dropped. However, if the partition location is not under the location of the partitioned table, it is not deleted as expected. Users can specify any location for the partition when they adding a partition. This PR is to delete partition location when dropping managed partitioned tables stored in `InMemoryCatalog`. ### How was this patch tested? Added test cases for both HiveExternalCatalog and InMemoryCatalog Author: gatorsmile <[email protected]> Closes apache#16448 from gatorsmile/unsetSerdeProp.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…rtitioned Tables in InMemoryCatalog ### What changes were proposed in this pull request? The data in the managed table should be deleted after table is dropped. However, if the partition location is not under the location of the partitioned table, it is not deleted as expected. Users can specify any location for the partition when they adding a partition. This PR is to delete partition location when dropping managed partitioned tables stored in `InMemoryCatalog`. ### How was this patch tested? Added test cases for both HiveExternalCatalog and InMemoryCatalog Author: gatorsmile <[email protected]> Closes apache#16448 from gatorsmile/unsetSerdeProp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The data in the managed table should be deleted after table is dropped. However, if the partition location is not under the location of the partitioned table, it is not deleted as expected. Users can specify any location for the partition when they adding a partition.
This PR is to delete partition location when dropping managed partitioned tables stored in
InMemoryCatalog.How was this patch tested?
Added test cases for both HiveExternalCatalog and InMemoryCatalog