[SPARK-18993][BUILD] Unable to build/compile Spark in IntelliJ due to missing Scala deps in spark-tags #16418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
CC @ryan-williams / @vanzin |
Contributor
|
good catch, thx |
|
Test build #70645 has finished for PR 16418 at commit
|
Member
|
It works well. LGTM |
asfgit
pushed a commit
that referenced
this pull request
Dec 28, 2016
… missing Scala deps in spark-tags ## What changes were proposed in this pull request? This adds back a direct dependency on Scala library classes from spark-tags because its Scala annotations need them. ## How was this patch tested? Existing tests Author: Sean Owen <[email protected]> Closes #16418 from srowen/SPARK-18993. (cherry picked from commit d7bce3b) Signed-off-by: Sean Owen <[email protected]>
Member
Author
|
Merged to master/2.1/2.0 to match the preceding change. I figured it's sort of important to get IDEs back online. |
asfgit
pushed a commit
that referenced
this pull request
Dec 28, 2016
… missing Scala deps in spark-tags ## What changes were proposed in this pull request? This adds back a direct dependency on Scala library classes from spark-tags because its Scala annotations need them. ## How was this patch tested? Existing tests Author: Sean Owen <[email protected]> Closes #16418 from srowen/SPARK-18993. (cherry picked from commit d7bce3b) Signed-off-by: Sean Owen <[email protected]>
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Dec 29, 2016
… missing Scala deps in spark-tags ## What changes were proposed in this pull request? This adds back a direct dependency on Scala library classes from spark-tags because its Scala annotations need them. ## How was this patch tested? Existing tests Author: Sean Owen <[email protected]> Closes apache#16418 from srowen/SPARK-18993.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
… missing Scala deps in spark-tags ## What changes were proposed in this pull request? This adds back a direct dependency on Scala library classes from spark-tags because its Scala annotations need them. ## How was this patch tested? Existing tests Author: Sean Owen <[email protected]> Closes apache#16418 from srowen/SPARK-18993.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This adds back a direct dependency on Scala library classes from spark-tags because its Scala annotations need them.
How was this patch tested?
Existing tests