[SPARK-18941][SQL][DOC] Add a new behavior document on CREATE/DROP TABLE with LOCATION
#16400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #70579 has finished for PR 16400 at commit
|
Member
Author
|
Hi, @gatorsmile . |
Member
Author
|
Hi @gatorsmile . |
gatorsmile
reviewed
Jan 7, 2017
docs/sql-programming-guide.md
Outdated
Member
There was a problem hiding this comment.
behavior. -> behavior for Hive tables.
gatorsmile
reviewed
Jan 7, 2017
docs/sql-programming-guide.md
Outdated
Member
There was a problem hiding this comment.
Nit: No need to show the JIRA here. Please remove it.
gatorsmile
reviewed
Jan 7, 2017
docs/sql-programming-guide.md
Outdated
Member
There was a problem hiding this comment.
Add the text here: That means, a Hive table created in Spark SQL with the user-specified location is always a Hive external table. Dropping external tables will not remove the data. Users are not allowed to specify the location for Hive managed tables. Note that this is different from the Hive behavior.
gatorsmile
reviewed
Jan 7, 2017
docs/sql-programming-guide.md
Outdated
Member
There was a problem hiding this comment.
Now, we can remove this sentence.
Member
Author
|
Thank you, @gatorsmile . I updated the commit and description of this PR. You can see the new image from generated doc. |
Member
|
LGTM |
|
Test build #71018 has finished for PR 16400 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Jan 8, 2017
…ABLE` with `LOCATION` ## What changes were proposed in this pull request? This PR adds a new behavior change description on `CREATE TABLE ... LOCATION` at `sql-programming-guide.md` clearly under `Upgrading From Spark SQL 1.6 to 2.0`. This change is introduced at Apache Spark 2.0.0 as [SPARK-15276](https://issues.apache.org/jira/browse/SPARK-15276). ## How was this patch tested? ``` SKIP_API=1 jekyll build ``` **Newly Added Description** <img width="913" alt="new" src="https://cloud.githubusercontent.com/assets/9700541/21743606/7efe2b12-d4ba-11e6-8a0d-551222718ea2.png"> Author: Dongjoon Hyun <[email protected]> Closes #16400 from dongjoon-hyun/SPARK-18941. (cherry picked from commit 923e594) Signed-off-by: gatorsmile <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Jan 8, 2017
…ABLE` with `LOCATION` ## What changes were proposed in this pull request? This PR adds a new behavior change description on `CREATE TABLE ... LOCATION` at `sql-programming-guide.md` clearly under `Upgrading From Spark SQL 1.6 to 2.0`. This change is introduced at Apache Spark 2.0.0 as [SPARK-15276](https://issues.apache.org/jira/browse/SPARK-15276). ## How was this patch tested? ``` SKIP_API=1 jekyll build ``` **Newly Added Description** <img width="913" alt="new" src="https://cloud.githubusercontent.com/assets/9700541/21743606/7efe2b12-d4ba-11e6-8a0d-551222718ea2.png"> Author: Dongjoon Hyun <[email protected]> Closes #16400 from dongjoon-hyun/SPARK-18941. (cherry picked from commit 923e594) Signed-off-by: gatorsmile <[email protected]>
Member
|
Thanks! Merging to master/2.1/2.0 |
Member
Author
|
Thank you for merging, @gatorsmile ! |
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Jan 9, 2017
…ABLE` with `LOCATION` ## What changes were proposed in this pull request? This PR adds a new behavior change description on `CREATE TABLE ... LOCATION` at `sql-programming-guide.md` clearly under `Upgrading From Spark SQL 1.6 to 2.0`. This change is introduced at Apache Spark 2.0.0 as [SPARK-15276](https://issues.apache.org/jira/browse/SPARK-15276). ## How was this patch tested? ``` SKIP_API=1 jekyll build ``` **Newly Added Description** <img width="913" alt="new" src="https://cloud.githubusercontent.com/assets/9700541/21743606/7efe2b12-d4ba-11e6-8a0d-551222718ea2.png"> Author: Dongjoon Hyun <[email protected]> Closes apache#16400 from dongjoon-hyun/SPARK-18941.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…ABLE` with `LOCATION` ## What changes were proposed in this pull request? This PR adds a new behavior change description on `CREATE TABLE ... LOCATION` at `sql-programming-guide.md` clearly under `Upgrading From Spark SQL 1.6 to 2.0`. This change is introduced at Apache Spark 2.0.0 as [SPARK-15276](https://issues.apache.org/jira/browse/SPARK-15276). ## How was this patch tested? ``` SKIP_API=1 jekyll build ``` **Newly Added Description** <img width="913" alt="new" src="https://cloud.githubusercontent.com/assets/9700541/21743606/7efe2b12-d4ba-11e6-8a0d-551222718ea2.png"> Author: Dongjoon Hyun <[email protected]> Closes apache#16400 from dongjoon-hyun/SPARK-18941.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds a new behavior change description on
CREATE TABLE ... LOCATIONatsql-programming-guide.mdclearly underUpgrading From Spark SQL 1.6 to 2.0. This change is introduced at Apache Spark 2.0.0 as SPARK-15276.How was this patch tested?
Newly Added Description
