[SPARK-18745][SQL] Fix signed integer overflow due to toInt cast #16235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM - pending jenkins. @kiszk do you think there is a sane way of testing this? |
Contributor
|
also cc @davies |
|
Test build #69926 has finished for PR 16235 at commit
|
Contributor
|
retest this please |
Contributor
|
LGTM, thanks for fixing it! |
Member
Author
|
@hvanhovell if we want to test these methods, it seems to be complicated since we have to allocate large |
Contributor
|
Ok, lets not do that for now. |
Contributor
|
It might at some point be an idea to add a bunch of asserts to |
|
Test build #69928 has finished for PR 16235 at commit
|
Member
Author
|
Jenkins, retest this please |
srowen
approved these changes
Dec 9, 2016
|
Test build #69930 has finished for PR 16235 at commit
|
Contributor
|
Merging to master/2.1/2.0. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Dec 9, 2016
## What changes were proposed in this pull request? This PR avoids that a result of a cast `toInt` is negative due to signed integer overflow (e.g. 0x0000_0000_1???????L.toInt < 0 ). This PR performs casts after we can ensure the value is within range of signed integer (the result of `max(array.length, ???)` is always integer). ## How was this patch tested? Manually executed query68 of TPC-DS with 100TB Author: Kazuaki Ishizaki <[email protected]> Closes #16235 from kiszk/SPARK-18745. (cherry picked from commit d60ab5f) Signed-off-by: Herman van Hovell <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Dec 9, 2016
## What changes were proposed in this pull request? This PR avoids that a result of a cast `toInt` is negative due to signed integer overflow (e.g. 0x0000_0000_1???????L.toInt < 0 ). This PR performs casts after we can ensure the value is within range of signed integer (the result of `max(array.length, ???)` is always integer). ## How was this patch tested? Manually executed query68 of TPC-DS with 100TB Author: Kazuaki Ishizaki <[email protected]> Closes #16235 from kiszk/SPARK-18745. (cherry picked from commit d60ab5f) Signed-off-by: Herman van Hovell <[email protected]>
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 15, 2016
## What changes were proposed in this pull request? This PR avoids that a result of a cast `toInt` is negative due to signed integer overflow (e.g. 0x0000_0000_1???????L.toInt < 0 ). This PR performs casts after we can ensure the value is within range of signed integer (the result of `max(array.length, ???)` is always integer). ## How was this patch tested? Manually executed query68 of TPC-DS with 100TB Author: Kazuaki Ishizaki <[email protected]> Closes apache#16235 from kiszk/SPARK-18745.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? This PR avoids that a result of a cast `toInt` is negative due to signed integer overflow (e.g. 0x0000_0000_1???????L.toInt < 0 ). This PR performs casts after we can ensure the value is within range of signed integer (the result of `max(array.length, ???)` is always integer). ## How was this patch tested? Manually executed query68 of TPC-DS with 100TB Author: Kazuaki Ishizaki <[email protected]> Closes apache#16235 from kiszk/SPARK-18745.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR avoids that a result of a cast
toIntis negative due to signed integer overflow (e.g. 0x0000_0000_1???????L.toInt < 0 ). This PR performs casts after we can ensure the value is within range of signed integer (the result ofmax(array.length, ???)is always integer).How was this patch tested?
Manually executed query68 of TPC-DS with 100TB