[SPARK-13747][Core]Fix potential ThreadLocal leaks in RPC when using ForkJoinPool #16230
+23
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Test build #69910 has started for PR 16230 at commit |
|
Test build #69929 has finished for PR 16230 at commit
|
|
Test build #69939 has finished for PR 16230 at commit
|
|
Test build #69950 has finished for PR 16230 at commit
|
|
Test build #3486 has finished for PR 16230 at commit
|
Contributor
|
LGTM |
Contributor
|
Merging to master |
asfgit
pushed a commit
that referenced
this pull request
Dec 13, 2016
…h 2.1, 2.0) ## What changes were proposed in this pull request? This PR fixes the timeout value in `awaitResultInForkJoinSafely` for 2.1 and 2.0. Master has been fixed by #16230. ## How was this patch tested? Jenkins Author: Shixiong Zhu <[email protected]> Closes #16268 from zsxwing/SPARK-18843.
asfgit
pushed a commit
that referenced
this pull request
Dec 13, 2016
…h 2.1, 2.0) ## What changes were proposed in this pull request? This PR fixes the timeout value in `awaitResultInForkJoinSafely` for 2.1 and 2.0. Master has been fixed by #16230. ## How was this patch tested? Jenkins Author: Shixiong Zhu <[email protected]> Closes #16268 from zsxwing/SPARK-18843. (cherry picked from commit f672bfd) Signed-off-by: Shixiong Zhu <[email protected]>
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 15, 2016
… ForkJoinPool ## What changes were proposed in this pull request? Some places in SQL may call `RpcEndpointRef.askWithRetry` (e.g., ParquetFileFormat.buildReader -> SparkContext.broadcast -> ... -> BlockManagerMaster.updateBlockInfo -> RpcEndpointRef.askWithRetry), which will finally call `Await.result`. It may cause `java.lang.IllegalArgumentException: spark.sql.execution.id is already set` when running in Scala ForkJoinPool. This PR includes the following changes to fix this issue: - Remove `ThreadUtils.awaitResult` - Rename `ThreadUtils. awaitResultInForkJoinSafely` to `ThreadUtils.awaitResult` - Replace `Await.result` in RpcTimeout with `ThreadUtils.awaitResult`. ## How was this patch tested? Jenkins Author: Shixiong Zhu <[email protected]> Closes apache#16230 from zsxwing/fix-SPARK-13747.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
… ForkJoinPool ## What changes were proposed in this pull request? Some places in SQL may call `RpcEndpointRef.askWithRetry` (e.g., ParquetFileFormat.buildReader -> SparkContext.broadcast -> ... -> BlockManagerMaster.updateBlockInfo -> RpcEndpointRef.askWithRetry), which will finally call `Await.result`. It may cause `java.lang.IllegalArgumentException: spark.sql.execution.id is already set` when running in Scala ForkJoinPool. This PR includes the following changes to fix this issue: - Remove `ThreadUtils.awaitResult` - Rename `ThreadUtils. awaitResultInForkJoinSafely` to `ThreadUtils.awaitResult` - Replace `Await.result` in RpcTimeout with `ThreadUtils.awaitResult`. ## How was this patch tested? Jenkins Author: Shixiong Zhu <[email protected]> Closes apache#16230 from zsxwing/fix-SPARK-13747.
sumwale
pushed a commit
to TIBCOSoftware/snappy-spark
that referenced
this pull request
Aug 12, 2021
… ForkJoinPool ## What changes were proposed in this pull request? Some places in SQL may call `RpcEndpointRef.askWithRetry` (e.g., ParquetFileFormat.buildReader -> SparkContext.broadcast -> ... -> BlockManagerMaster.updateBlockInfo -> RpcEndpointRef.askWithRetry), which will finally call `Await.result`. It may cause `java.lang.IllegalArgumentException: spark.sql.execution.id is already set` when running in Scala ForkJoinPool. This PR includes the following changes to fix this issue: - Remove `ThreadUtils.awaitResult` - Rename `ThreadUtils. awaitResultInForkJoinSafely` to `ThreadUtils.awaitResult` - Replace `Await.result` in RpcTimeout with `ThreadUtils.awaitResult`. ## How was this patch tested? Jenkins Author: Shixiong Zhu <[email protected]> Closes apache#16230 from zsxwing/fix-SPARK-13747.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Some places in SQL may call
RpcEndpointRef.askWithRetry(e.g., ParquetFileFormat.buildReader -> SparkContext.broadcast -> ... -> BlockManagerMaster.updateBlockInfo -> RpcEndpointRef.askWithRetry), which will finally callAwait.result. It may causejava.lang.IllegalArgumentException: spark.sql.execution.id is already setwhen running in Scala ForkJoinPool.This PR includes the following changes to fix this issue:
ThreadUtils.awaitResultThreadUtils. awaitResultInForkJoinSafelytoThreadUtils.awaitResultAwait.resultin RpcTimeout withThreadUtils.awaitResult.How was this patch tested?
Jenkins