[SPARK-18762][WEBUI] Web UI should be http:4040 instead of https:4040 #16190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarutak
changed the title
|
Test build #69781 has started for PR 16190 at commit |
Member
|
I think the jira number should be SPARK-18762, instead of SPARK-18761. |
sarutak
changed the title
Member
Author
|
@viirya Thanks! I've fixed it. |
Member
Author
Member
Author
|
cc: @mengxr |
Member
Author
|
Of course, HistoryServer works with SSL enabled.
|
sarutak
changed the title
Member
Author
|
Also, Spark Shell says as follows. |
|
Test build #69790 has finished for PR 16190 at commit
|
Contributor
Contributor
|
@mengxr that change is actually incorrect and shouldn't have been merged. (The test changes in the same patch are ok though.) This one LGTM. |
Contributor
|
merging to master / 2.1 |
Contributor
|
Hmm, looks like the original change is in branch-2.0 also, let me try to merge there too. |
asfgit
pushed a commit
that referenced
this pull request
Dec 7, 2016
## What changes were proposed in this pull request? When SSL is enabled, the Spark shell shows: ``` Spark context Web UI available at https://192.168.99.1:4040 ``` This is wrong because 4040 is http, not https. It redirects to the https port. More importantly, this introduces several broken links in the UI. For example, in the master UI, the worker link is https:8081 instead of http:8081 or https:8481. CC: mengxr liancheng I manually tested accessing by accessing MasterPage, WorkerPage and HistoryServer with SSL enabled. Author: sarutak <[email protected]> Closes #16190 from sarutak/SPARK-18761. (cherry picked from commit bb94f61) Signed-off-by: Marcelo Vanzin <[email protected]>
Contributor
|
Merged to 2.0 also. |
asfgit
pushed a commit
that referenced
this pull request
Dec 7, 2016
## What changes were proposed in this pull request? When SSL is enabled, the Spark shell shows: ``` Spark context Web UI available at https://192.168.99.1:4040 ``` This is wrong because 4040 is http, not https. It redirects to the https port. More importantly, this introduces several broken links in the UI. For example, in the master UI, the worker link is https:8081 instead of http:8081 or https:8481. CC: mengxr liancheng I manually tested accessing by accessing MasterPage, WorkerPage and HistoryServer with SSL enabled. Author: sarutak <[email protected]> Closes #16190 from sarutak/SPARK-18761. (cherry picked from commit bb94f61) Signed-off-by: Marcelo Vanzin <[email protected]>
Contributor
|
@sarutak Thanks for the quick fix! |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 15, 2016
## What changes were proposed in this pull request? When SSL is enabled, the Spark shell shows: ``` Spark context Web UI available at https://192.168.99.1:4040 ``` This is wrong because 4040 is http, not https. It redirects to the https port. More importantly, this introduces several broken links in the UI. For example, in the master UI, the worker link is https:8081 instead of http:8081 or https:8481. CC: mengxr liancheng I manually tested accessing by accessing MasterPage, WorkerPage and HistoryServer with SSL enabled. Author: sarutak <[email protected]> Closes apache#16190 from sarutak/SPARK-18761.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? When SSL is enabled, the Spark shell shows: ``` Spark context Web UI available at https://192.168.99.1:4040 ``` This is wrong because 4040 is http, not https. It redirects to the https port. More importantly, this introduces several broken links in the UI. For example, in the master UI, the worker link is https:8081 instead of http:8081 or https:8481. CC: mengxr liancheng I manually tested accessing by accessing MasterPage, WorkerPage and HistoryServer with SSL enabled. Author: sarutak <[email protected]> Closes apache#16190 from sarutak/SPARK-18761.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When SSL is enabled, the Spark shell shows:
This is wrong because 4040 is http, not https. It redirects to the https port.
More importantly, this introduces several broken links in the UI. For example, in the master UI, the worker link is https:8081 instead of http:8081 or https:8481.
CC: @mengxr @liancheng
I manually tested accessing by accessing MasterPage, WorkerPage and HistoryServer with SSL enabled.