[SPARK-18760][SQL] Consistent format specification for FileFormats #16187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @cloud-fan |
Contributor
Author
|
Actually if possible please merge this in branch-2.1. |
|
Test build #69772 has finished for PR 16187 at commit
|
|
Test build #69779 has started for PR 16187 at commit |
gatorsmile
reviewed
Dec 7, 2016
| override def shortName(): String = "parquet" | ||
|
|
||
| override def toString: String = "ParquetFormat" | ||
| override def toString: String = "Parquet" |
Member
There was a problem hiding this comment.
Just did a quick check. The other formats are using upper cases. Do you think we need to make them consistent? JSON, CSV and ORC
Contributor
Author
There was a problem hiding this comment.
All the other formats are acronyms.
Member
There was a problem hiding this comment.
Yeah. Got it. The offical documents of these three formats are using upper cases.
Member
|
LGTM pending test. |
|
Test build #3473 has finished for PR 16187 at commit
|
Member
|
retest this please |
|
Test build #69812 has finished for PR 16187 at commit
|
Member
|
retest this please |
|
Test build #3474 has finished for PR 16187 at commit
|
|
Test build #69834 has finished for PR 16187 at commit
|
Member
|
retest this please |
|
Test build #69848 has started for PR 16187 at commit |
|
Test build #3478 has finished for PR 16187 at commit
|
Contributor
Seems the PR description is outdated? We still depend on |
Contributor
Author
|
Fixed- let me merge this in master/branch-2.1. |
asfgit
pushed a commit
that referenced
this pull request
Dec 8, 2016
## What changes were proposed in this pull request?
This patch fixes the format specification in explain for file sources (Parquet and Text formats are the only two that are different from the rest):
Before:
```
scala> spark.read.text("test.text").explain()
== Physical Plan ==
*FileScan text [value#15] Batched: false, Format: org.apache.spark.sql.execution.datasources.text.TextFileFormatxyz, Location: InMemoryFileIndex[file:/scratch/rxin/spark/test.text], PartitionFilters: [], PushedFilters: [], ReadSchema: struct<value:string>
```
After:
```
scala> spark.read.text("test.text").explain()
== Physical Plan ==
*FileScan text [value#15] Batched: false, Format: Text, Location: InMemoryFileIndex[file:/scratch/rxin/spark/test.text], PartitionFilters: [], PushedFilters: [], ReadSchema: struct<value:string>
```
Also closes #14680.
## How was this patch tested?
Verified in spark-shell.
Author: Reynold Xin <[email protected]>
Closes #16187 from rxin/SPARK-18760.
(cherry picked from commit 5f894d2)
Signed-off-by: Reynold Xin <[email protected]>
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 15, 2016
## What changes were proposed in this pull request?
This patch fixes the format specification in explain for file sources (Parquet and Text formats are the only two that are different from the rest):
Before:
```
scala> spark.read.text("test.text").explain()
== Physical Plan ==
*FileScan text [value#15] Batched: false, Format: org.apache.spark.sql.execution.datasources.text.TextFileFormatxyz, Location: InMemoryFileIndex[file:/scratch/rxin/spark/test.text], PartitionFilters: [], PushedFilters: [], ReadSchema: struct<value:string>
```
After:
```
scala> spark.read.text("test.text").explain()
== Physical Plan ==
*FileScan text [value#15] Batched: false, Format: Text, Location: InMemoryFileIndex[file:/scratch/rxin/spark/test.text], PartitionFilters: [], PushedFilters: [], ReadSchema: struct<value:string>
```
Also closes apache#14680.
## How was this patch tested?
Verified in spark-shell.
Author: Reynold Xin <[email protected]>
Closes apache#16187 from rxin/SPARK-18760.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request?
This patch fixes the format specification in explain for file sources (Parquet and Text formats are the only two that are different from the rest):
Before:
```
scala> spark.read.text("test.text").explain()
== Physical Plan ==
*FileScan text [value#15] Batched: false, Format: org.apache.spark.sql.execution.datasources.text.TextFileFormatxyz, Location: InMemoryFileIndex[file:/scratch/rxin/spark/test.text], PartitionFilters: [], PushedFilters: [], ReadSchema: struct<value:string>
```
After:
```
scala> spark.read.text("test.text").explain()
== Physical Plan ==
*FileScan text [value#15] Batched: false, Format: Text, Location: InMemoryFileIndex[file:/scratch/rxin/spark/test.text], PartitionFilters: [], PushedFilters: [], ReadSchema: struct<value:string>
```
Also closes apache#14680.
## How was this patch tested?
Verified in spark-shell.
Author: Reynold Xin <[email protected]>
Closes apache#16187 from rxin/SPARK-18760.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch fixes the format specification in explain for file sources (Parquet and Text formats are the only two that are different from the rest):
Before:
After:
Also closes #14680.
How was this patch tested?
Verified in spark-shell.