Skip to content

Conversation

@aray
Copy link
Contributor

@aray aray commented Dec 6, 2016

What changes were proposed in this pull request?

Fixes AnalysisException for pivot queries that have group by columns that are expressions and not attributes by substituting the expressions output attribute in the second aggregation and final projection.

How was this patch tested?

existing and additional unit tests

@SparkQA
Copy link

SparkQA commented Dec 6, 2016

Test build #69743 has finished for PR 16177 at commit 0924765.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Dec 7, 2016

cc @cloud-fan / @hvanhovell

@cloud-fan
Copy link
Contributor

good catch! LGTM, cc @hvanhovell to take another look.

@hvanhovell
Copy link
Contributor

LGTM. Merging to master/2.1. Thanks!

@hvanhovell
Copy link
Contributor

@aray could you open a backport for branch 2.0 if you feel that we should also fix it there?

@asfgit asfgit closed this in f1fca81 Dec 7, 2016
asfgit pushed a commit that referenced this pull request Dec 7, 2016
…y column is not attribute

## What changes were proposed in this pull request?

Fixes AnalysisException for pivot queries that have group by columns that are expressions and not attributes by substituting the expressions output attribute in the second aggregation and final projection.

## How was this patch tested?

existing and additional unit tests

Author: Andrew Ray <[email protected]>

Closes #16177 from aray/SPARK-17760.

(cherry picked from commit f1fca81)
Signed-off-by: Herman van Hovell <[email protected]>
asfgit pushed a commit that referenced this pull request Dec 7, 2016
…hen groupBy column is not attribute

## What changes were proposed in this pull request?

Backport of #16177 to branch-2.0

## How was this patch tested?

existing and additional unit tests

Author: Andrew Ray <[email protected]>

Closes #16197 from aray/SPARK-17760-2.0.
robert3005 pushed a commit to palantir/spark that referenced this pull request Dec 15, 2016
…y column is not attribute

## What changes were proposed in this pull request?

Fixes AnalysisException for pivot queries that have group by columns that are expressions and not attributes by substituting the expressions output attribute in the second aggregation and final projection.

## How was this patch tested?

existing and additional unit tests

Author: Andrew Ray <[email protected]>

Closes apache#16177 from aray/SPARK-17760.
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
…y column is not attribute

## What changes were proposed in this pull request?

Fixes AnalysisException for pivot queries that have group by columns that are expressions and not attributes by substituting the expressions output attribute in the second aggregation and final projection.

## How was this patch tested?

existing and additional unit tests

Author: Andrew Ray <[email protected]>

Closes apache#16177 from aray/SPARK-17760.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants