[SPARK-18734][SS] Represent timestamp in StreamingQueryProgress as formatted string instead of millis #16166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #69710 has finished for PR 16166 at commit
|
zsxwing
reviewed
Dec 6, 2016
Member
zsxwing
left a comment
zsxwing
left a comment
There was a problem hiding this comment.
One minor issue about the time zone. Otherwise, LGTM.
| // The timestamp we report an event that has no input data | ||
| private var lastNoDataProgressEventTime = Long.MinValue | ||
|
|
||
| private val timestampFormat = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'") // ISO8601 |
Member
There was a problem hiding this comment.
You need to set the timezone before using this format. Otherwise, the time is based on your timezone. E.g.,
scala> new java.util.Date()
res7: java.util.Date = Tue Dec 06 10:48:00 PST 2016
scala> val timestampFormat = new java.text.SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'")
timestampFormat: java.text.SimpleDateFormat = java.text.SimpleDateFormat@5af7aed5
scala> timestampFormat.format(new java.util.Date())
res8: String = 2016-12-06T10:48:09.342Z
scala> val timestampFormat = new java.text.SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'")
timestampFormat: java.text.SimpleDateFormat = java.text.SimpleDateFormat@5af7aed5
scala> timestampFormat.setTimeZone(java.util.TimeZone.getTimeZone("UTC"))
scala> timestampFormat.format(new java.util.Date())
res10: String = 2016-12-06T18:48:20.048Z
|
Test build #69749 has finished for PR 16166 at commit
|
Member
|
LGTM. Merging to master and 2.1. |
asfgit
pushed a commit
that referenced
this pull request
Dec 7, 2016
…rmatted string instead of millis ## What changes were proposed in this pull request? Easier to read while debugging as a formatted string (in ISO8601 format) than in millis ## How was this patch tested? Updated unit tests Author: Tathagata Das <[email protected]> Closes #16166 from tdas/SPARK-18734. (cherry picked from commit 539bb3c) Signed-off-by: Shixiong Zhu <[email protected]>
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 15, 2016
…rmatted string instead of millis ## What changes were proposed in this pull request? Easier to read while debugging as a formatted string (in ISO8601 format) than in millis ## How was this patch tested? Updated unit tests Author: Tathagata Das <[email protected]> Closes apache#16166 from tdas/SPARK-18734.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…rmatted string instead of millis ## What changes were proposed in this pull request? Easier to read while debugging as a formatted string (in ISO8601 format) than in millis ## How was this patch tested? Updated unit tests Author: Tathagata Das <[email protected]> Closes apache#16166 from tdas/SPARK-18734.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Easier to read while debugging as a formatted string (in ISO8601 format) than in millis
How was this patch tested?
Updated unit tests