[SPARK-12446][SQL][BACKPORT-1.6] Add unit tests for JDBCRDD internal functions #16124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No tests done for JDBCRDD#compileFilter. Author: Takeshi YAMAMURO <[email protected]> Closes #10409 from maropu/AddTestsInJdbcRdd. (cherry picked from commit 8c1b867)
Member
Author
|
This is the first commit for #16021. |
Member
|
Can you please add [Backport-1.6] to the PR title? |
dongjoon-hyun
changed the title
Member
Author
|
Sorry for missing that tag. Thank you! |
|
Test build #69595 has finished for PR 16124 at commit
|
Member
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Dec 3, 2016
…functions No tests done for JDBCRDD#compileFilter. Author: Takeshi YAMAMURO <linguin.m.sgmail.com> Closes #10409 from maropu/AddTestsInJdbcRdd. (cherry picked from commit 8c1b867) Author: Takeshi YAMAMURO <[email protected]> Closes #16124 from dongjoon-hyun/SPARK-12446-BRANCH-1.6.
Member
|
Thanks! Merged to 1.6. Could you close the PR? |
Member
Author
|
Thank you! I'll close this and proceed to next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No tests done for JDBCRDD#compileFilter.
Author: Takeshi YAMAMURO [email protected]
Closes #10409 from maropu/AddTestsInJdbcRdd.
(cherry picked from commit 8c1b867)