Skip to content

SPARK-18677: Fix parsing ['key'] in JSON path expressions. #16107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

SPARK-18677: Fix parsing ['key'] in JSON path expressions. #16107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ private[this] object JsonPathParser extends RegexParsers {
// parse `.name` or `['name']` child expressions
def named: Parser[List[PathInstruction]] =
for {
name <- '.' ~> "[^\\.\\[]+".r | "[\\'" ~> "[^\\'\\?]+" <~ "\\']"
name <- '.' ~> "[^\\.\\[]+".r | "['" ~> "[^\\'\\?]+".r <~ "']"
} yield {
Key :: Named(name) :: Nil
}
Expand Down
24 changes: 24 additions & 0 deletions ...alyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/JsonExpressionsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,30 @@ class JsonExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
"""{"price":19.95,"color":"red"}""")
}

test("$['store'].bicycle") {
checkEvaluation(
GetJsonObject(Literal(json), Literal("$['store'].bicycle")),
"""{"price":19.95,"color":"red"}""")
}

test("$.store['bicycle']") {
checkEvaluation(
GetJsonObject(Literal(json), Literal("$.store['bicycle']")),
"""{"price":19.95,"color":"red"}""")
}

test("$['store']['bicycle']") {
checkEvaluation(
GetJsonObject(Literal(json), Literal("$['store']['bicycle']")),
"""{"price":19.95,"color":"red"}""")
}

test("$['key with spaces']") {
checkEvaluation(GetJsonObject(
Literal("""{ "key with spaces": "it works" }"""), Literal("$['key with spaces']")),
"it works")
}

test("$.store.book") {
checkEvaluation(
GetJsonObject(Literal(json), Literal("$.store.book")),
Expand Down