Skip to content

Conversation

@cenyuhai
Copy link
Contributor

@cenyuhai cenyuhai commented Dec 1, 2016

What changes were proposed in this pull request?

set statement state to error after user canceled job

@cenyuhai cenyuhai changed the title [SPARK-18665][SQL] set statement state to error after user canceled job [SPARK-18665][SQL] set statement state to "ERROR" after user canceled job Dec 1, 2016
@cenyuhai cenyuhai changed the title [SPARK-18665][SQL] set statement state to "ERROR" after user canceled job [SPARK-18665][SQL] set statement state to "ERROR" after user cancel job Dec 1, 2016
@SparkQA
Copy link

SparkQA commented Dec 1, 2016

Test build #69472 has finished for PR 16099 at commit e3a9b08.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Dec 1, 2016

cc @liancheng

@SparkQA
Copy link

SparkQA commented Dec 2, 2016

Test build #69547 has finished for PR 16099 at commit 196ab66.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 6, 2016

Test build #69719 has finished for PR 16099 at commit ddb4128.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 6, 2016

Test build #69720 has finished for PR 16099 at commit 501d121.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 6, 2016

Test build #69727 has finished for PR 16099 at commit 40894a1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

} catch {
case e: HiveSQLException =>
HiveThriftServer2.listener.onStatementError(
statementId, e.getMessage, SparkUtils.exceptionString(e))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried your code. there seems have a bug.
e.getMessage may get a null value, which may cause NPE in ThriftServerPage.errorMessageCell(detail)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR still occurs in Spark 2.2.1. A workaround is to use "String.valueOf(e.getMessage)" instead of "e.getMessage" to avoid of NPE problem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, but My pr is closed by community...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please catch the exception in ThriftServerPage.errorMessageCell. Without my pr, that function still throw exception.

@gatorsmile
Copy link
Member

cc @cenyuhai

@cenyuhai
Copy link
Contributor Author

cenyuhai commented Feb 5, 2018

@gatorsmile two years passed... I don't know what to say.

@tooptoop4
Copy link
Contributor

@cenyuhai want to open new pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants