-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-18665][SQL] set statement state to "ERROR" after user cancel job #16099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #69472 has finished for PR 16099 at commit
|
|
cc @liancheng |
|
Test build #69547 has finished for PR 16099 at commit
|
|
Test build #69719 has finished for PR 16099 at commit
|
|
Test build #69720 has finished for PR 16099 at commit
|
|
Test build #69727 has finished for PR 16099 at commit
|
| } catch { | ||
| case e: HiveSQLException => | ||
| HiveThriftServer2.listener.onStatementError( | ||
| statementId, e.getMessage, SparkUtils.exceptionString(e)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried your code. there seems have a bug.
e.getMessage may get a null value, which may cause NPE in ThriftServerPage.errorMessageCell(detail)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR still occurs in Spark 2.2.1. A workaround is to use "String.valueOf(e.getMessage)" instead of "e.getMessage" to avoid of NPE problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, but My pr is closed by community...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please catch the exception in ThriftServerPage.errorMessageCell. Without my pr, that function still throw exception.
|
cc @cenyuhai |
|
@gatorsmile two years passed... I don't know what to say. |
|
@cenyuhai want to open new pr? |
What changes were proposed in this pull request?
set statement state to error after user canceled job