Skip to content

Conversation

@viirya
Copy link
Member

@viirya viirya commented Dec 1, 2016

What changes were proposed in this pull request?

spark.sql.unsafe.enabled is deprecated since 1.6. There still are codes in UI to check it. We should remove it and clean the codes.

How was this patch tested?

Changes to related existing unit test.

Please review http://spark.apache.org/contributing.html before opening a pull request.

@viirya viirya changed the title [UI] Remove the codes checking deprecated config spark.sql.unsafe.enabled [SPARK-18666][Web UI] Remove the codes checking deprecated config spark.sql.unsafe.enabled Dec 1, 2016
@SparkQA
Copy link

SparkQA commented Dec 1, 2016

Test build #69452 has finished for PR 16095 at commit 1bf8528.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks unused now.

@rxin
Copy link
Contributor

rxin commented Dec 1, 2016

Merging in master/branch-2.1.

@asfgit asfgit closed this in dbf842b Dec 1, 2016
asfgit pushed a commit that referenced this pull request Dec 1, 2016
…rk.sql.unsafe.enabled

## What changes were proposed in this pull request?

`spark.sql.unsafe.enabled` is deprecated since 1.6. There still are codes in UI to check it. We should remove it and clean the codes.

## How was this patch tested?

Changes to related existing unit test.

Please review http://spark.apache.org/contributing.html before opening a pull request.

Author: Liang-Chi Hsieh <[email protected]>

Closes #16095 from viirya/remove-deprecated-config-code.

(cherry picked from commit dbf842b)
Signed-off-by: Reynold Xin <[email protected]>
robert3005 pushed a commit to palantir/spark that referenced this pull request Dec 2, 2016
…rk.sql.unsafe.enabled

## What changes were proposed in this pull request?

`spark.sql.unsafe.enabled` is deprecated since 1.6. There still are codes in UI to check it. We should remove it and clean the codes.

## How was this patch tested?

Changes to related existing unit test.

Please review http://spark.apache.org/contributing.html before opening a pull request.

Author: Liang-Chi Hsieh <[email protected]>

Closes apache#16095 from viirya/remove-deprecated-config-code.
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
…rk.sql.unsafe.enabled

## What changes were proposed in this pull request?

`spark.sql.unsafe.enabled` is deprecated since 1.6. There still are codes in UI to check it. We should remove it and clean the codes.

## How was this patch tested?

Changes to related existing unit test.

Please review http://spark.apache.org/contributing.html before opening a pull request.

Author: Liang-Chi Hsieh <[email protected]>

Closes apache#16095 from viirya/remove-deprecated-config-code.
@viirya viirya deleted the remove-deprecated-config-code branch December 27, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants