Skip to content

Conversation

@yanboliang
Copy link
Contributor

@yanboliang yanboliang commented Nov 29, 2016

What changes were proposed in this pull request?

This is follow-up for #15788, spark.glm can encode probability to prediction by SQLTransformer rather than reimplementing a new transformer.

How was this patch tested?

Existing tests.

@yanboliang
Copy link
Contributor Author

cc @jkbradley @felixcheung

@SparkQA
Copy link

SparkQA commented Nov 29, 2016

Test build #69320 has finished for PR 16058 at commit 7644e97.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheung
Copy link
Member

LGTM

@yanboliang
Copy link
Contributor Author

Since we decided revert SPARK-18291 for 2.1 and add it back after SPARK-18618 resolved, I can directly add this change at that time. So I will close this PR. Thanks for reviewing.

@yanboliang yanboliang closed this Dec 2, 2016
@yanboliang yanboliang deleted the spark-18291-2 branch December 2, 2016 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants