[SPARK-16282][SQL] Follow-up: remove "percentile" from temp function detection after implementing it natively #16049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…detection after implementing it natively
Contributor
|
LGTM pending Jenkins. |
|
Test build #69283 has finished for PR 16049 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Nov 29, 2016
…detection after implementing it natively ## What changes were proposed in this pull request? In #15764 we added a mechanism to detect if a function is temporary or not. Hive functions are treated as non-temporary. Of the three hive functions, now "percentile" has been implemented natively, and "hash" has been removed. So we should update the list. ## How was this patch tested? Unit tests. Author: Shuai Lin <[email protected]> Closes #16049 from lins05/update-temp-function-detect-hive-list. (cherry picked from commit e64a204) Signed-off-by: gatorsmile <[email protected]>
Member
|
Merging to master/2.1! Thanks! |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 2, 2016
…detection after implementing it natively ## What changes were proposed in this pull request? In apache#15764 we added a mechanism to detect if a function is temporary or not. Hive functions are treated as non-temporary. Of the three hive functions, now "percentile" has been implemented natively, and "hash" has been removed. So we should update the list. ## How was this patch tested? Unit tests. Author: Shuai Lin <[email protected]> Closes apache#16049 from lins05/update-temp-function-detect-hive-list.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…detection after implementing it natively ## What changes were proposed in this pull request? In apache#15764 we added a mechanism to detect if a function is temporary or not. Hive functions are treated as non-temporary. Of the three hive functions, now "percentile" has been implemented natively, and "hash" has been removed. So we should update the list. ## How was this patch tested? Unit tests. Author: Shuai Lin <[email protected]> Closes apache#16049 from lins05/update-temp-function-detect-hive-list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In #15764 we added a mechanism to detect if a function is temporary or not. Hive functions are treated as non-temporary. Of the three hive functions, now "percentile" has been implemented natively, and "hash" has been removed. So we should update the list.
How was this patch tested?
Unit tests.