Skip to content

Conversation

@cloud-fan
Copy link
Contributor

What changes were proposed in this pull request?

Technically map type is not orderable, but can be used in equality comparison. However, due to the limitation of the current implementation, map type can't be used in equality comparison so that it can't be join key or grouping key.

This PR makes this limitation explicit, to avoid wrong result.

backport #15956 to 2.0

How was this patch tested?

updated tests

@cloud-fan
Copy link
Contributor Author

cc @hvanhovell

@SparkQA
Copy link

SparkQA commented Nov 23, 2016

Test build #69056 has started for PR 15988 at commit acfa6ba.

@hvanhovell
Copy link
Contributor

retest this please

@SparkQA
Copy link

SparkQA commented Nov 23, 2016

Test build #69065 has finished for PR 15988 at commit acfa6ba.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@hvanhovell
Copy link
Contributor

LGTM. Merging to 2.0. Thanks!

Can you close?

asfgit pushed a commit that referenced this pull request Nov 23, 2016
## What changes were proposed in this pull request?

Technically map type is not orderable, but can be used in equality comparison. However, due to the limitation of the current implementation, map type can't be used in equality comparison so that it can't be join key or grouping key.

This PR makes this limitation explicit, to avoid wrong result.

backport #15956 to 2.0

## How was this patch tested?
updated tests

Author: Wenchen Fan <[email protected]>

Closes #15988 from cloud-fan/map-type.
@cloud-fan cloud-fan closed this Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants