[SPARK-2529] Clean closures in foreach and foreachPartition. #1583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA tests have started for PR 1583. This patch merges cleanly. |
|
QA results for PR 1583: |
Contributor
|
LGTM - probably good to backport as well |
Contributor
|
Does anyone recall why we lost the closure cleaning in 6b288b7 ? |
Contributor
Author
|
Unfortunately I can't think of why I did that. |
Contributor
|
Yeah weird, it must've been an oversight while editing. Unfortunately the apache/incubator-spark repo is gone so we can't see the old PRs and comments on them... |
Contributor
Author
|
Merged in master & branch-1.0. |
asfgit
pushed a commit
that referenced
this pull request
Jul 25, 2014
Author: Reynold Xin <[email protected]> Closes #1583 from rxin/closureClean and squashes the following commits: 8982fe6 [Reynold Xin] [SPARK-2529] Clean closures in foreach and foreachPartition. (cherry picked from commit eb82abd) Signed-off-by: Reynold Xin <[email protected]>
xiliu82
pushed a commit
to xiliu82/spark
that referenced
this pull request
Sep 4, 2014
Author: Reynold Xin <[email protected]> Closes apache#1583 from rxin/closureClean and squashes the following commits: 8982fe6 [Reynold Xin] [SPARK-2529] Clean closures in foreach and foreachPartition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.