[SPARK-18191][CORE][FOLLOWUP] Call setConf if OutputFormat is Configurable.
#15823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
rxin
reviewed
Nov 9, 2016
|
|
||
| protected def setupCommitter(context: TaskAttemptContext): OutputCommitter = { | ||
| context.getOutputFormatClass.newInstance().getOutputCommitter(context) | ||
| val format = context.getOutputFormatClass.newInstance |
Contributor
There was a problem hiding this comment.
use newInstance() since it is not just a simple getter.
Contributor
|
LGTM otherwise. |
|
Test build #68384 has finished for PR 15823 at commit
|
Contributor
|
LGTM. Not at my laptop, would be great if you can merge @rxin, thanks. |
|
Test build #68391 has finished for PR 15823 at commit
|
Contributor
|
Merging in master. |
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…nfigurable`. ## What changes were proposed in this pull request? We should call `setConf` if `OutputFormat` is `Configurable`, this should be done before we create `OutputCommitter` and `RecordWriter`. This is follow up of apache#15769, see discussion [here](https://github.com/apache/spark/pull/15769/files#r87064229) ## How was this patch tested? Add test of this case in `PairRDDFunctionsSuite`. Author: jiangxingbo <[email protected]> Closes apache#15823 from jiangxb1987/config-format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We should call
setConfifOutputFormatisConfigurable, this should be done before we createOutputCommitterandRecordWriter.This is follow up of #15769, see discussion here
How was this patch tested?
Add test of this case in
PairRDDFunctionsSuite.