[SPARK-14914][CORE]:Fix Resource not closed after using, for unit tests and example #15818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #68379 has finished for PR 15818 at commit
|
srowen
approved these changes
Nov 9, 2016
Member
|
OK, I can merge this. This is getting confusing because 7 pull requests have been piled on one JIRA. I get that they're related and sometimes we have follow-ups but now we don't even have the changes merged into all the same branch. I think I will go back and merge all 3 related PRs into branch-2.1 to make sure we're consistent, including this one. |
Member
|
Merged to master; see #15618 (comment) |
Contributor
Author
|
@srowen Thanks! Next time, I will file a new JIRA if I do for the same reason. |
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…ts and example ## What changes were proposed in this pull request? This is a follow-up work of apache#15618. Close file source; For any newly created streaming context outside the withContext, explicitly close the context. ## How was this patch tested? Existing unit tests. Author: [email protected] <[email protected]> Closes apache#15818 from wangmiao1981/rtest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up work of #15618.
Close file source;
For any newly created streaming context outside the withContext, explicitly close the context.
How was this patch tested?
Existing unit tests.