Skip to content

Conversation

@ericl
Copy link
Contributor

@ericl ericl commented Nov 7, 2016

What changes were proposed in this pull request?

These are no longer needed after https://issues.apache.org/jira/browse/SPARK-17183

cc @cloud-fan

How was this patch tested?

Existing parquet and orc tests.

@ericl ericl changed the title [SPARK-18333] Revert hacks in parquet and orc reader to support case insensitive resolution [SPARK-18333] [SQL] Revert hacks in parquet and orc reader to support case insensitive resolution Nov 7, 2016
@SparkQA
Copy link

SparkQA commented Nov 7, 2016

Test build #68296 has finished for PR 15799 at commit 8921868.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Md5(child: Expression) extends UnaryExpression with ImplicitCastInputTypes
    • case class Sha2(left: Expression, right: Expression)
    • case class Sha1(child: Expression) extends UnaryExpression with ImplicitCastInputTypes
    • case class Crc32(child: Expression) extends UnaryExpression with ImplicitCastInputTypes
    • abstract class HashExpression[E] extends Expression
    • abstract class InterpretedHashFunction
    • case class Murmur3Hash(children: Seq[Expression], seed: Int) extends HashExpression[Int]
    • case class XxHash64(children: Seq[Expression], seed: Long) extends HashExpression[Long]
    • case class HiveHash(children: Seq[Expression]) extends HashExpression[Int]
    • abstract class RDG extends UnaryExpression with ExpectsInputTypes with Nondeterministic
    • case class Rand(child: Expression) extends RDG
    • case class Randn(child: Expression) extends RDG

@ericl
Copy link
Contributor Author

ericl commented Nov 7, 2016

jenkins retest this please

@cloud-fan
Copy link
Contributor

LGTM, can you also point out which PR added this hack? thanks.

@SparkQA
Copy link

SparkQA commented Nov 8, 2016

Test build #68304 has finished for PR 15799 at commit 8921868.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Md5(child: Expression) extends UnaryExpression with ImplicitCastInputTypes
    • case class Sha2(left: Expression, right: Expression)
    • case class Sha1(child: Expression) extends UnaryExpression with ImplicitCastInputTypes
    • case class Crc32(child: Expression) extends UnaryExpression with ImplicitCastInputTypes
    • abstract class HashExpression[E] extends Expression
    • abstract class InterpretedHashFunction
    • case class Murmur3Hash(children: Seq[Expression], seed: Int) extends HashExpression[Int]
    • case class XxHash64(children: Seq[Expression], seed: Long) extends HashExpression[Long]
    • case class HiveHash(children: Seq[Expression]) extends HashExpression[Int]
    • abstract class RDG extends UnaryExpression with ExpectsInputTypes with Nondeterministic
    • case class Rand(child: Expression) extends RDG
    • case class Randn(child: Expression) extends RDG

@ericl
Copy link
Contributor Author

ericl commented Nov 8, 2016

The hacks were added in #14690

@SparkQA
Copy link

SparkQA commented Nov 9, 2016

Test build #68374 has finished for PR 15799 at commit 7f02648.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

LGTM

asfgit pushed a commit that referenced this pull request Nov 9, 2016
…case insensitive resolution

## What changes were proposed in this pull request?

These are no longer needed after https://issues.apache.org/jira/browse/SPARK-17183

cc cloud-fan

## How was this patch tested?

Existing parquet and orc tests.

Author: Eric Liang <[email protected]>

Closes #15799 from ericl/sc-4929.

(cherry picked from commit 4afa39e)
Signed-off-by: Wenchen Fan <[email protected]>
@cloud-fan
Copy link
Contributor

merging to master/2.1

@asfgit asfgit closed this in 4afa39e Nov 9, 2016
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
…case insensitive resolution

## What changes were proposed in this pull request?

These are no longer needed after https://issues.apache.org/jira/browse/SPARK-17183

cc cloud-fan

## How was this patch tested?

Existing parquet and orc tests.

Author: Eric Liang <[email protected]>

Closes apache#15799 from ericl/sc-4929.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants