Skip to content

Conversation

@zhengruifeng
Copy link
Contributor

What changes were proposed in this pull request?

1, **Example** => **Examples**, because more algos use **Examples**.
2, delete ### Examples in Isotonic regression, because it's not that special in http://spark.apache.org/docs/latest/ml-classification-regression.html
3, add missing marks for LDA and other algos.

How was this patch tested?

No tests for it only modify doc

@SparkQA
Copy link

SparkQA commented Nov 5, 2016

Test build #68190 has finished for PR 15783 at commit 4cd524c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this standardization overall. Here you still have a ## section though, was that intended?

Copy link
Contributor Author

@zhengruifeng zhengruifeng Nov 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hesitated about whether to modify this place. For there are not may links in http://spark.apache.org/docs/latest/ml-tuning.html like those in featureAlgos http://spark.apache.org/docs/latest/ml-features.html.
But now, I tend to use **examples...** for standardization.

@SparkQA
Copy link

SparkQA commented Nov 7, 2016

Test build #68257 has finished for PR 15783 at commit bf59358.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Nov 8, 2016

Merged to master

@asfgit asfgit closed this in b1033fb Nov 8, 2016
@zhengruifeng zhengruifeng deleted the doc_fix branch November 9, 2016 03:12
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
## What changes were proposed in this pull request?
1, `**Example**` => `**Examples**`, because more algos use `**Examples**`.
2,  delete `### Examples` in `Isotonic regression`, because it's not that special in http://spark.apache.org/docs/latest/ml-classification-regression.html
3, add missing marks for `LDA` and other algos.

## How was this patch tested?
No tests for it only modify doc

Author: Zheng RuiFeng <[email protected]>

Closes apache#15783 from zhengruifeng/doc_fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants