[SPARK-18210][ML] Pipeline.copy does not create an instance with the same UID #15759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtek-szymanski
changed the title
wojtek-szymanski
changed the title
wojtek-szymanski
changed the title
|
Test build #3412 has finished for PR 15759 at commit
|
Contributor
|
LGTM, merged into master and branch-2.1. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Nov 6, 2016
…same UID ## What changes were proposed in this pull request? Motivation: `org.apache.spark.ml.Pipeline.copy(extra: ParamMap)` does not create an instance with the same UID. It does not conform to the method specification from its base class `org.apache.spark.ml.param.Params.copy(extra: ParamMap)` Solution: - fix for Pipeline UID - introduced new tests for `org.apache.spark.ml.Pipeline.copy` - minor improvements in test for `org.apache.spark.ml.PipelineModel.copy` ## How was this patch tested? Introduced new unit test: `org.apache.spark.ml.PipelineSuite."Pipeline.copy"` Improved existing unit test: `org.apache.spark.ml.PipelineSuite."PipelineModel.copy"` Author: Wojciech Szymanski <[email protected]> Closes #15759 from wojtek-szymanski/SPARK-18210. (cherry picked from commit b89d055) Signed-off-by: Yanbo Liang <[email protected]>
Contributor
Author
|
My pleasure, thanks. |
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…same UID ## What changes were proposed in this pull request? Motivation: `org.apache.spark.ml.Pipeline.copy(extra: ParamMap)` does not create an instance with the same UID. It does not conform to the method specification from its base class `org.apache.spark.ml.param.Params.copy(extra: ParamMap)` Solution: - fix for Pipeline UID - introduced new tests for `org.apache.spark.ml.Pipeline.copy` - minor improvements in test for `org.apache.spark.ml.PipelineModel.copy` ## How was this patch tested? Introduced new unit test: `org.apache.spark.ml.PipelineSuite."Pipeline.copy"` Improved existing unit test: `org.apache.spark.ml.PipelineSuite."PipelineModel.copy"` Author: Wojciech Szymanski <[email protected]> Closes apache#15759 from wojtek-szymanski/SPARK-18210.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Motivation:
org.apache.spark.ml.Pipeline.copy(extra: ParamMap)does not create an instance with the same UID. It does not conform to the method specification from its base classorg.apache.spark.ml.param.Params.copy(extra: ParamMap)Solution:
org.apache.spark.ml.Pipeline.copyorg.apache.spark.ml.PipelineModel.copyHow was this patch tested?
Introduced new unit test:
org.apache.spark.ml.PipelineSuite."Pipeline.copy"Improved existing unit test:
org.apache.spark.ml.PipelineSuite."PipelineModel.copy"