Skip to content

Conversation

@baishuo
Copy link
Contributor

@baishuo baishuo commented Jul 24, 2014

I think it's better to defined hiveQlTable as a val

I think it's better to defined hiveQlTable as a val
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@marmbrus
Copy link
Contributor

test this please

@marmbrus
Copy link
Contributor

Please include [SQL] in the PR title for anything that changes Spark SQL.

@SparkQA
Copy link

SparkQA commented Jul 25, 2014

QA tests have started for PR 1569. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17154/consoleFull

@baishuo baishuo changed the title Update HiveMetastoreCatalog.scala [SQL]Update HiveMetastoreCatalog.scala Jul 25, 2014
@baishuo
Copy link
Contributor Author

baishuo commented Jul 25, 2014

modify the title, add [SQL]

@marmbrus
Copy link
Contributor

I guess it is a def since it is not serializable...

You could make it a @transient lazy val.

BTW you can run the tests locally: sbt/sbt catalyst/test sql/test hive/test

@baishuo
Copy link
Contributor Author

baishuo commented Jul 25, 2014

thank you @marmbrus , I had modify it to "@transient lazy val" and the run "sbt/sbt catalyst/test sql/test hive/test" at master branch , all test passed. if only "val", test can not passed.

the following is the tail of results of test:

[info] - Partition pruning - with filter on string partition key - query test
[info] - Partition pruning - with filter on int partition key - pruning test
[info] - Partition pruning - with filter on int partition key - query test
[info] - Partition pruning - left only 1 partition - pruning test
[info] - Partition pruning - left only 1 partition - query test
[info] - Partition pruning - all partitions pruned - pruning test
[info] - Partition pruning - all partitions pruned - query test
[info] - Partition pruning - pruning with both column key and partition key - pruning test
[info] - Partition pruning - pruning with both column key and partition key - query test
[info] HiveResolutionSuite:
[info] - table.attr
[info] - database.table
[info] - database.table table.attr
[info] - alias.attr
[info] - subquery-alias.attr
[info] - quoted alias.attr
[info] - attr
[info] - alias.star
[info] - case insensitivity with scala reflection
[info] - nested repeated resolution
[info] BigDataBenchmarkSuite:
[info] - No data files found for BigDataBenchmark tests. !!! IGNORED !!!
[info] ScalaTest
[info] Run completed in 2 minutes, 55 seconds.
[info] Total number of tests run: 150
[info] Suites: completed 14, aborted 0
[info] Tests: succeeded 150, failed 0, canceled 0, ignored 7, pending 0
[info] All tests passed.
[info] Passed: Total 150, Failed 0, Errors 0, Passed 150, Ignored 7
[success] Total time: 267 s, completed Jul 25, 2014 10:17:09 AM

@marmbrus
Copy link
Contributor

test this please

@SparkQA
Copy link

SparkQA commented Jul 25, 2014

QA tests have started for PR 1569. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17194/consoleFull

@SparkQA
Copy link

SparkQA commented Jul 25, 2014

QA results for PR 1569:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17194/consoleFull

@marmbrus
Copy link
Contributor

Thanks, I merged this into master.

@asfgit asfgit closed this in ab3c6a4 Jul 25, 2014
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
I think it's better to defined hiveQlTable as a val

Author: baishuo(白硕) <[email protected]>

Closes apache#1569 from baishuo/patch-1 and squashes the following commits:

dc2f895 [baishuo(白硕)] Update HiveMetastoreCatalog.scala
a7b32a2 [baishuo(白硕)] Update HiveMetastoreCatalog.scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants