Skip to content

Conversation

@zsxwing
Copy link
Member

@zsxwing zsxwing commented Oct 26, 2016

What changes were proposed in this pull request?

Backport #15520 to 2.0.

How was this patch tested?

Jenkins

Calling `Await.result` will allow other tasks to be run on the same thread when using ForkJoinPool. However, SQL uses a `ThreadLocal` execution id to trace Spark jobs launched by a query, which doesn't work perfectly in ForkJoinPool.

This PR just uses `Awaitable.result` instead to  prevent ForkJoinPool from running other tasks in the current waiting thread.

Jenkins

Author: Shixiong Zhu <[email protected]>

Closes #15520 from zsxwing/SPARK-13747.

(cherry picked from commit 7ac70e7)
Signed-off-by: Shixiong Zhu <[email protected]>
@SparkQA
Copy link

SparkQA commented Oct 26, 2016

Test build #67591 has finished for PR 15646 at commit eba011a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member Author

zsxwing commented Oct 26, 2016

Merging to 2.0.

asfgit pushed a commit that referenced this pull request Oct 26, 2016
…(branch 2.0)

## What changes were proposed in this pull request?

Backport #15520 to 2.0.

## How was this patch tested?

Jenkins

Author: Shixiong Zhu <[email protected]>

Closes #15646 from zsxwing/SPARK-13747-2.0.
@zsxwing zsxwing closed this Oct 26, 2016
@zsxwing zsxwing deleted the SPARK-13747-2.0 branch October 26, 2016 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants