[SPARK-18070][SQL] binary operator should not consider nullability when comparing input types #15606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Member
|
This bug only affects the complex type, ( |
|
Test build #67437 has finished for PR 15606 at commit
|
Contributor
Author
|
@gatorsmile yup, the |
Member
|
LGTM |
Member
|
retest this please |
|
Test build #67519 has finished for PR 15606 at commit
|
Contributor
|
LGTM. Merging to master and branch 2.0. |
asfgit
pushed a commit
that referenced
this pull request
Oct 25, 2016
…en comparing input types ## What changes were proposed in this pull request? Binary operator requires its inputs to be of same type, but it should not consider nullability, e.g. `EqualTo` should be able to compare an element-nullable array and an element-non-nullable array. ## How was this patch tested? a regression test in `DataFrameSuite` Author: Wenchen Fan <[email protected]> Closes #15606 from cloud-fan/type-bug. (cherry picked from commit a21791e) Signed-off-by: Yin Huai <[email protected]>
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Nov 1, 2016
…en comparing input types ## What changes were proposed in this pull request? Binary operator requires its inputs to be of same type, but it should not consider nullability, e.g. `EqualTo` should be able to compare an element-nullable array and an element-non-nullable array. ## How was this patch tested? a regression test in `DataFrameSuite` Author: Wenchen Fan <[email protected]> Closes apache#15606 from cloud-fan/type-bug.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…en comparing input types ## What changes were proposed in this pull request? Binary operator requires its inputs to be of same type, but it should not consider nullability, e.g. `EqualTo` should be able to compare an element-nullable array and an element-non-nullable array. ## How was this patch tested? a regression test in `DataFrameSuite` Author: Wenchen Fan <[email protected]> Closes apache#15606 from cloud-fan/type-bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Binary operator requires its inputs to be of same type, but it should not consider nullability, e.g.
EqualToshould be able to compare an element-nullable array and an element-non-nullable array.How was this patch tested?
a regression test in
DataFrameSuite