[SPARK-18044][STREAMING] FileStreamSource should not infer partitions in every batch #15581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test build #67331 has finished for PR 15581 at commit
|
Member
|
LGTM. Merging to master |
Member
|
@cloud-fan there are conflicts with 2.0. Could you submit another PR for that? |
Contributor
Author
|
yea of course, I'll do it soon |
Contributor
Author
Member
Done. I also merged this one into branch 2.0. |
asfgit
pushed a commit
that referenced
this pull request
Oct 24, 2016
… in every batch ## What changes were proposed in this pull request? In `FileStreamSource.getBatch`, we will create a `DataSource` with specified schema, to avoid inferring the schema again and again. However, we don't pass the partition columns, and will infer the partition again and again. This PR fixes it by keeping the partition columns in `FileStreamSource`, like schema. ## How was this patch tested? N/A Author: Wenchen Fan <[email protected]> Closes #15581 from cloud-fan/stream.
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Nov 1, 2016
… in every batch ## What changes were proposed in this pull request? In `FileStreamSource.getBatch`, we will create a `DataSource` with specified schema, to avoid inferring the schema again and again. However, we don't pass the partition columns, and will infer the partition again and again. This PR fixes it by keeping the partition columns in `FileStreamSource`, like schema. ## How was this patch tested? N/A Author: Wenchen Fan <[email protected]> Closes apache#15581 from cloud-fan/stream.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
… in every batch ## What changes were proposed in this pull request? In `FileStreamSource.getBatch`, we will create a `DataSource` with specified schema, to avoid inferring the schema again and again. However, we don't pass the partition columns, and will infer the partition again and again. This PR fixes it by keeping the partition columns in `FileStreamSource`, like schema. ## How was this patch tested? N/A Author: Wenchen Fan <[email protected]> Closes apache#15581 from cloud-fan/stream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In
FileStreamSource.getBatch, we will create aDataSourcewith specified schema, to avoid inferring the schema again and again. However, we don't pass the partition columns, and will infer the partition again and again.This PR fixes it by keeping the partition columns in
FileStreamSource, like schema.How was this patch tested?
N/A