[DOCS] Update docs to not suggest to package Spark before running tests. #15572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I believe that's right; @vanzin can probably confirm. I have usually built the assembly anyway when I test. |
vanzin
reviewed
Oct 20, 2016
docs/building-spark.md
Outdated
| ./build/sbt -Pyarn -Phadoop-2.3 -Phive -Phive-thriftserver package | ||
| ./build/sbt -Pyarn -Phadoop-2.3 -Phive -Phive-thriftserver test | ||
|
|
||
| Note, previously some tests required Spark to be packaged first before running them, so an explicit `build/sbt package` was required the first time. That is no longer required. |
Contributor
There was a problem hiding this comment.
Not sure it's necessary to mention this.
|
Test build #67295 has finished for PR 15572 at commit
|
Contributor
|
LGTM, merging to master. |
|
Test build #67299 has finished for PR 15572 at commit
|
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Nov 1, 2016
## What changes were proposed in this pull request? Update docs to not suggest to package Spark before running tests. ## How was this patch tested? Not creating a JIRA since this pretty small. We haven't had the need to run mvn package before mvn test since 1.6 at least, or so I am told. So, updating the docs to not be misguiding. Author: Mark Grover <[email protected]> Closes apache#15572 from markgrover/doc_update.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? Update docs to not suggest to package Spark before running tests. ## How was this patch tested? Not creating a JIRA since this pretty small. We haven't had the need to run mvn package before mvn test since 1.6 at least, or so I am told. So, updating the docs to not be misguiding. Author: Mark Grover <[email protected]> Closes apache#15572 from markgrover/doc_update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update docs to not suggest to package Spark before running tests.
How was this patch tested?
Not creating a JIRA since this pretty small. We haven't had the need to run mvn package before mvn test since 1.6 at least, or so I am told. So, updating the docs to not be misguiding.