[SPARK-18029][SQL] PruneFileSourcePartitions should not change the output of LogicalRelation #15569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
mallman
reviewed
Oct 20, 2016
| def toRow(partitionSchema: StructType): InternalRow = { | ||
| InternalRow.fromSeq(partitionSchema.map { case StructField(name, dataType, _, _) => | ||
| Cast(Literal(spec(name)), dataType).eval() | ||
| InternalRow.fromSeq(partitionSchema.map { field => |
Contributor
There was a problem hiding this comment.
Why are you proposing this change?
Contributor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
I see. Do we have a Spark style guide?
Contributor
There was a problem hiding this comment.
There is this one: https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide
But it is fairly basic.
Contributor
There was a problem hiding this comment.
Ok. This change makes sense to me.
|
Test build #67269 has finished for PR 15569 at commit
|
Contributor
|
LGTM. |
Contributor
Author
|
thanks for the review, merging to master! |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Nov 1, 2016
…tput of LogicalRelation ## What changes were proposed in this pull request? In `PruneFileSourcePartitions`, we will replace the `LogicalRelation` with a pruned one. However, this replacement may change the output of the `LogicalRelation` if it doesn't have `expectedOutputAttributes`. This PR fixes it. ## How was this patch tested? the new `PruneFileSourcePartitionsSuite` Author: Wenchen Fan <[email protected]> Closes apache#15569 from cloud-fan/partition-bug.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…tput of LogicalRelation ## What changes were proposed in this pull request? In `PruneFileSourcePartitions`, we will replace the `LogicalRelation` with a pruned one. However, this replacement may change the output of the `LogicalRelation` if it doesn't have `expectedOutputAttributes`. This PR fixes it. ## How was this patch tested? the new `PruneFileSourcePartitionsSuite` Author: Wenchen Fan <[email protected]> Closes apache#15569 from cloud-fan/partition-bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In
PruneFileSourcePartitions, we will replace theLogicalRelationwith a pruned one. However, this replacement may change the output of theLogicalRelationif it doesn't haveexpectedOutputAttributes. This PR fixes it.How was this patch tested?
the new
PruneFileSourcePartitionsSuite