[SPARK-18021][SQL] Refactor file name specification for data sources #15562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxin
changed the title
Contributor
Author
|
cc @liancheng @cloud-fan @tejasapatil also @marmbrus -- you have always wanted this to happen. |
|
Test build #67241 has finished for PR 15562 at commit
|
cloud-fan
reviewed
Oct 20, 2016
| private val recordWriter: RecordWriter[Void, InternalRow] = { | ||
| val outputFormat = { | ||
| new ParquetOutputFormat[InternalRow]() { | ||
| // Here we override `getDefaultWorkFile` for two reasons: |
Contributor
There was a problem hiding this comment.
why remove this comment?
Contributor
Author
There was a problem hiding this comment.
Basically the only contract now is that prefix needs to be enforced, and it is not the concern of these classes to think about dynamic partitioning or appending.
Contributor
|
LGTM |
|
Test build #67244 has finished for PR 15562 at commit
|
liancheng
reviewed
Oct 20, 2016
Contributor
liancheng
left a comment
liancheng
left a comment
There was a problem hiding this comment.
LGTM pending Jenkins. Left one minor comment though.
| // implementations may use this UUID to generate unique file names (e.g., | ||
| // `part-r-<task-id>-<job-uuid>.parquet`). The reason why this ID is used to identify a job | ||
| // rather than a single task output file is that, speculative tasks must generate the same | ||
| // output file name as the original task. |
Contributor
There was a problem hiding this comment.
We should probably preserve this comment and move it to the new place where we generate the UUID.
Contributor
Author
There was a problem hiding this comment.
It's actually there already in WriteJobDescription. I shortened it to a single line.
|
Test build #67273 has finished for PR 15562 at commit
|
Contributor
Author
|
Alright merging this in master. I will submit more patches to continue this work. |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Nov 1, 2016
## What changes were proposed in this pull request? Currently each data source OutputWriter is responsible for specifying the entire file name for each file output. This, however, does not make any sense because we rely on file naming schemes for certain behaviors in Spark SQL, e.g. bucket id. The current approach allows individual data sources to break the implementation of bucketing. On the flip side, we also don't want to move file naming entirely out of data sources, because different data sources do want to specify different extensions. This patch divides file name specification into two parts: the first part is a prefix specified by the caller of OutputWriter (in WriteOutput), and the second part is the suffix that can be specified by the OutputWriter itself. Note that a side effect of this change is that now all file based data sources also support bucketing automatically. There are also some other minor cleanups: - Removed the UUID passed through generic Configuration string - Some minor rewrites for better clarity - Renamed "path" in multiple places to "stagingDir", to more accurately reflect its meaning ## How was this patch tested? This should be covered by existing data source tests. Author: Reynold Xin <[email protected]> Closes apache#15562 from rxin/SPARK-18021.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? Currently each data source OutputWriter is responsible for specifying the entire file name for each file output. This, however, does not make any sense because we rely on file naming schemes for certain behaviors in Spark SQL, e.g. bucket id. The current approach allows individual data sources to break the implementation of bucketing. On the flip side, we also don't want to move file naming entirely out of data sources, because different data sources do want to specify different extensions. This patch divides file name specification into two parts: the first part is a prefix specified by the caller of OutputWriter (in WriteOutput), and the second part is the suffix that can be specified by the OutputWriter itself. Note that a side effect of this change is that now all file based data sources also support bucketing automatically. There are also some other minor cleanups: - Removed the UUID passed through generic Configuration string - Some minor rewrites for better clarity - Renamed "path" in multiple places to "stagingDir", to more accurately reflect its meaning ## How was this patch tested? This should be covered by existing data source tests. Author: Reynold Xin <[email protected]> Closes apache#15562 from rxin/SPARK-18021.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently each data source OutputWriter is responsible for specifying the entire file name for each file output. This, however, does not make any sense because we rely on file naming schemes for certain behaviors in Spark SQL, e.g. bucket id. The current approach allows individual data sources to break the implementation of bucketing.
On the flip side, we also don't want to move file naming entirely out of data sources, because different data sources do want to specify different extensions.
This patch divides file name specification into two parts: the first part is a prefix specified by the caller of OutputWriter (in WriteOutput), and the second part is the suffix that can be specified by the OutputWriter itself. Note that a side effect of this change is that now all file based data sources also support bucketing automatically.
There are also some other minor cleanups:
How was this patch tested?
This should be covered by existing data source tests.