[SPARK-17974] (try 2) Refactor FileCatalog classes to simplify the inheritance tree #15533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y the inheritance tree"" This reverts commit 1c5a7d7.
Contributor
|
Can you put the proper description here still? It becomes part of the commit msg. |
|
Test build #67136 has finished for PR 15533 at commit
|
Contributor
|
Merging in master. Thanks. |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Nov 1, 2016
…eritance tree ## What changes were proposed in this pull request? This renames `BasicFileCatalog => FileCatalog`, combines `SessionFileCatalog` with `PartitioningAwareFileCatalog`, and removes the old `FileCatalog` trait. In summary, ``` MetadataLogFileCatalog extends PartitioningAwareFileCatalog ListingFileCatalog extends PartitioningAwareFileCatalog PartitioningAwareFileCatalog extends FileCatalog TableFileCatalog extends FileCatalog ``` (note that this is a re-submission of apache#15518 which got reverted) ## How was this patch tested? Existing tests Author: Eric Liang <[email protected]> Closes apache#15533 from ericl/fix-scalastyle-revert.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…eritance tree ## What changes were proposed in this pull request? This renames `BasicFileCatalog => FileCatalog`, combines `SessionFileCatalog` with `PartitioningAwareFileCatalog`, and removes the old `FileCatalog` trait. In summary, ``` MetadataLogFileCatalog extends PartitioningAwareFileCatalog ListingFileCatalog extends PartitioningAwareFileCatalog PartitioningAwareFileCatalog extends FileCatalog TableFileCatalog extends FileCatalog ``` (note that this is a re-submission of apache#15518 which got reverted) ## How was this patch tested? Existing tests Author: Eric Liang <[email protected]> Closes apache#15533 from ericl/fix-scalastyle-revert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This renames
BasicFileCatalog => FileCatalog, combinesSessionFileCatalogwithPartitioningAwareFileCatalog, and removes the oldFileCatalogtrait.In summary,
(note that this is a re-submission of #15518 which got reverted)
How was this patch tested?
Existing tests