[SPARK-17960][PySpark] [Upgrade to Py4J 0.10.4] #15514
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #67075 has finished for PR 15514 at commit
|
|
Test build #3356 has finished for PR 15514 at commit
|
Contributor
|
Awesome, thanks for taking this on @jagadeesanas2, this looks pretty reasonable although it might be helpful if we mentioned briefly the PR description what the Py4J changes were in this release since that is what ends up as the commit description once its merged. But the change its self looks good to me - cc @srowen / @davies for the final review. |
Contributor
|
cc @JoshRosen |
Member
|
I'm OK with it. For the record, was there any fix here that impacts Spark? updating just to keep updated isn't a bad idea but wouldn't want to update through every version of everything. Maybe at least once per minor release it's worth review. |
Member
|
Merged to master |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Nov 1, 2016
## What changes were proposed in this pull request? 1) Upgrade the Py4J version on the Java side 2) Update the py4j src zip file we bundle with Spark ## How was this patch tested? Existing doctests & unit tests pass Author: Jagadeesan <[email protected]> Closes apache#15514 from jagadeesanas2/SPARK-17960.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? 1) Upgrade the Py4J version on the Java side 2) Update the py4j src zip file we bundle with Spark ## How was this patch tested? Existing doctests & unit tests pass Author: Jagadeesan <[email protected]> Closes apache#15514 from jagadeesanas2/SPARK-17960.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?
Existing doctests & unit tests pass