[SPARK-17905] [SQL] [TEST] Added test cases for InMemoryRelation #15462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #66884 has finished for PR 15462 at commit
|
Member
Author
|
Jenkins, retest this please |
|
Test build #66889 has finished for PR 15462 at commit
|
Member
Author
andrewor14
suggested changes
Nov 22, 2016
Contributor
andrewor14
left a comment
andrewor14
left a comment
There was a problem hiding this comment.
@kiszk This looks good, a few minor code organization comments.
|
|
||
| assert(inMemoryRelation.cachedColumnBuffers.getStorageLevel == storageLevel) | ||
| inMemoryRelation.cachedColumnBuffers.collect().head match { | ||
| case _: CachedBatch => assert(true) |
Contributor
There was a problem hiding this comment.
no need to do assert true here
|
|
||
| test("all data type w && w/o nullability") { | ||
| // all primitives | ||
| Seq(true, false).map { nullability => |
Contributor
There was a problem hiding this comment.
can you split these into 2 separate tests? It's more debuggable that way. I would use a private helper method to abstract the logic
Member
Author
There was a problem hiding this comment.
OK. I created smaller multiple tests
|
|
||
| test("access only some column of the all of columns") { | ||
| val df = spark.range(1, 100).map(i => (i, (i + 1).toFloat)).toDF("i", "f").cache | ||
| df.count |
Contributor
There was a problem hiding this comment.
please be explicit with the actions here count(), cache()
| checkAnswer(df, row) | ||
| } | ||
|
|
||
| withSQLConf(SQLConf.WHOLESTAGE_MAX_NUM_FIELDS.key -> "2") { |
Contributor
There was a problem hiding this comment.
similarly can you split these into multiple smaller unit tests?
|
|
||
| setupTestData() | ||
|
|
||
| def cachePrimitiveTest(data: DataFrame, dataType: String) { |
Contributor
|
retest this please |
|
Test build #69025 has finished for PR 15462 at commit
|
|
Test build #69138 has finished for PR 15462 at commit
|
Member
Author
|
@andrewor14 thank you for your review. Could you please see it again? |
Contributor
|
LGTM, merging into master 2.1 thanks. |
asfgit
pushed a commit
that referenced
this pull request
Nov 28, 2016
## What changes were proposed in this pull request? This pull request adds test cases for the following cases: - keep all data types with null or without null - access `CachedBatch` disabling whole stage codegen - access only some columns in `CachedBatch` This PR is a part of #15219. Here are motivations to add these tests. When #15219 is enabled, the first two cases are handled by specialized (generated) code. The third one is a pitfall. In general, even for now, it would be helpful to increase test coverage. ## How was this patch tested? added test suites itself Author: Kazuaki Ishizaki <[email protected]> Closes #15462 from kiszk/columnartestsuites.
Contributor
|
@kiszk is there a JIRA associated specifically with adding tests for |
kiszk
changed the title
Member
Author
|
Thank you for pointing out an JIRA issue. I made a correction to a JIRA entry. |
Member
|
Done. Corrected the JIRA. Thanks! |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 2, 2016
## What changes were proposed in this pull request? This pull request adds test cases for the following cases: - keep all data types with null or without null - access `CachedBatch` disabling whole stage codegen - access only some columns in `CachedBatch` This PR is a part of apache#15219. Here are motivations to add these tests. When apache#15219 is enabled, the first two cases are handled by specialized (generated) code. The third one is a pitfall. In general, even for now, it would be helpful to increase test coverage. ## How was this patch tested? added test suites itself Author: Kazuaki Ishizaki <[email protected]> Closes apache#15462 from kiszk/columnartestsuites.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? This pull request adds test cases for the following cases: - keep all data types with null or without null - access `CachedBatch` disabling whole stage codegen - access only some columns in `CachedBatch` This PR is a part of apache#15219. Here are motivations to add these tests. When apache#15219 is enabled, the first two cases are handled by specialized (generated) code. The third one is a pitfall. In general, even for now, it would be helpful to increase test coverage. ## How was this patch tested? added test suites itself Author: Kazuaki Ishizaki <[email protected]> Closes apache#15462 from kiszk/columnartestsuites.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pull request adds test cases for the following cases:
CachedBatchdisabling whole stage codegenCachedBatchThis PR is a part of #15219. Here are motivations to add these tests. When #15219 is enabled, the first two cases are handled by specialized (generated) code. The third one is a pitfall.
In general, even for now, it would be helpful to increase test coverage.
How was this patch tested?
added test suites itself