[SPARK-17792][ML] L-BFGS solver for linear regression does not accept general numeric label column types #15364
+11
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
Author
|
also ping @BenFradet |
|
Test build #66404 has finished for PR 15364 at commit
|
Contributor
|
Lgtm 👍 |
Contributor
|
Merged into master and branch-2.0, thanks! |
asfgit
pushed a commit
that referenced
this pull request
Oct 7, 2016
… general numeric label column types ## What changes were proposed in this pull request? Before, we computed `instances` in LinearRegression in two spots, even though they did the same thing. One of them did not cast the label column to `DoubleType`. This patch consolidates the computation and always casts the label column to `DoubleType`. ## How was this patch tested? Added a unit test to check all solvers. This test failed before this patch. Author: sethah <[email protected]> Closes #15364 from sethah/linreg_numeric_type. (cherry picked from commit 3713bb1) Signed-off-by: Yanbo Liang <[email protected]>
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
… general numeric label column types ## What changes were proposed in this pull request? Before, we computed `instances` in LinearRegression in two spots, even though they did the same thing. One of them did not cast the label column to `DoubleType`. This patch consolidates the computation and always casts the label column to `DoubleType`. ## How was this patch tested? Added a unit test to check all solvers. This test failed before this patch. Author: sethah <[email protected]> Closes apache#15364 from sethah/linreg_numeric_type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Before, we computed
instancesin LinearRegression in two spots, even though they did the same thing. One of them did not cast the label column toDoubleType. This patch consolidates the computation and always casts the label column toDoubleType.How was this patch tested?
Added a unit test to check all solvers. This test failed before this patch.